Always read and write nodejs runtime options from/to the environment #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
approved these changes
Jan 11, 2021
pgavlin
reviewed
Jan 12, 2021
|
@EvanBoyle any chance you could add some tests and close this out this week? |
…odeRuntimeOpts
|
@pgavlin good catch, I had actually forgotten that this should apply to config as well. I updated the config code to always read/write from the environment as well. I also added some settings tests that round trip some mutations to options and config and then check the resulting environment variables. Our node config module already has some extensive tests that lend additional confidence to this change. |
komalali
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6059 Fixes #6041.
See #6059 for more detail on why this is necessary. TLDR; is that nodejs package resolution can result in multiple copies of a given package in the
node_modulestree, and thus multiple runtime options variables that can get out of sync (specifically for automation API where the lifetime of runtime options is managed manually).In order for settings to be shared appropriately in the instance where an inline program and a provider sdk dependency both bring in different copies of
@pulumi/pulumi, we must read and write settings via the environment and avoid caching values.