Improve nodejs automation api inline error handling #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBoyle
added
the
impact/no-changelog-required
lblackstone
approved these changes
Feb 2, 2021
komalali
approved these changes
Feb 2, 2021
| const defaultMessage = err.stack || err.message || ("" + err); | ||
| let defaultMessage = "" | ||
| if (!!err) { | ||
| defaultMessage = err.stack || err.message || ("" + err); |
There was a problem hiding this comment.
What's the relevance of the "" + err? Is that a string conversion?
sdk/nodejs/x/automation/stack.ts
Outdated
| let upResult; | ||
| try { | ||
| upResult = await this.runPulumiCmd(args, opts?.onOutput); | ||
| onExit(); |
There was a problem hiding this comment.
Is this onExit() necessary? Doesn't the finally block run regardless of error?
There was a problem hiding this comment.
You are right. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds several improvements to our error handling for nodejs inline programs run via Automation API. Along the way, I also cleaned up a bunch of unused functionality from
server.ts(exposing aresultpromise, providing an unused CLI exit code, etc). Summary of fixes:LanguageServeris always torn down cleanly (otherwise causes failed programs to hang)Errorare handled properly, even if user code throws an error without any details, exception message, etc.LanguageServer.Runshould respond with errors via calling thecallbackfunction https://avi.im/grpc-errors/#nodeFixes #6153
Fixes #5853
Fixes #6057