[cli] Disable permalinks to the update details page when using self-managed backends (S3, Azure, GCS) #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infin8x
approved these changes
Feb 4, 2021
stack72
force-pushed
the
nonSaaS-suppress-permalink
branch
from
5dc9bc1
to
b1d28fc
Compare
lukehoban
reviewed
Feb 4, 2021
stack72
force-pushed
the
nonSaaS-suppress-permalink
branch
from
34afac1
to
5631ac1
Compare
stack72
changed the title
stack72
force-pushed
the
nonSaaS-suppress-permalink
branch
from
5631ac1
to
67bf30f
Compare
stack72
changed the title
stack72
force-pushed
the
nonSaaS-suppress-permalink
branch
from
67bf30f
to
a8aa4ba
Compare
komalali
approved these changes
Feb 19, 2021
CHANGELOG.md
Outdated
| @@ -65,7 +72,7 @@ CHANGELOG | |||
|
|
|||
| - [automation/python] Fixed a bug in nested configuration parsing. | |||
| [#6349](https://github.com/pulumi/pulumi/pull/6349) | |||
|
|
|||
…naged backends (S3, Azure, GCS) Fixes: #4029 Fixes: #3537 Should the user want to get permalinks when using a self-managed backend, they can pass a flag: ``` $ pulumi up --suppress-permalink false ``` Permalinks for these self-managed backends will be suppressed on `update`, `preview`, `destroy`, `import` and `refresh` operations.
stack72
force-pushed
the
nonSaaS-suppress-permalink
branch
from
a8aa4ba
to
c77a1a9
Compare
lukehoban
approved these changes
Feb 19, 2021
| cmdutil.Diag().Warningf(diag.Message("", "Could not get signed url for stack location: %v"), err) | ||
| cmdutil.Diag().Warningf(diag.Message("", "Unable to create signed url for current backend to "+ | ||
| "create a Permalink. Please visit https://www.pulumi.com/docs/troubleshooting/ "+ | ||
| "for more information\n")) |
There was a problem hiding this comment.
Is there going to be text at this link to help with this? What are the cases where this will happen, and what actually should the user do?
There was a problem hiding this comment.
There are 2 places the docs will be updated
The troubleshooting section will have details as to why they get an open bucket url error - it's usually regarding using an Azure and GCp service principal to log into the self managed backends
I will also be updating the state and backends page to talk about the new defaults here of not showing a permalink
Both will be ready early Monday morning PST to make sure they are ready to go
|
when trying this in WLS2 , the syntax is slightly different from above if you actually want to add the argument: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4029
Fixes: #3537
Should the user want to get permalinks when using a self-managed backend, they can pass a flag:
Permalinks for these self-managed backends will be suppressed on
update,preview,destroy,importandrefreshoperations.A view of the functionality:
self-managed backend
Using the SaaS