Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/sdk] - Correctly handle outputs with properties named "values" #6264

Merged
merged 3 commits into from
Feb 6, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Feb 5, 2021

Fixes: #6000

The test case errors before the change and succeeds after.

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdk/python/lib/test/test_next_serialize.py Outdated Show resolved Hide resolved
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
@komalali komalali merged commit f374b8a into master Feb 6, 2021
@pulumi-bot pulumi-bot deleted the komalali/python-rpc-error branch February 6, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contains_unknowns fails if val contains a "values" key
2 participants