Fix mustWrite for Input/Output PropertyMaps #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from using `reflect.DeepEqual` to using PropertyMap's `DeepEquals` directly for Inputs and Outputs. This avoids issues with `reflect.DeepEqual` treating `nil` and empty arrays as non-equal. These appear to have been triggered recently by https://github.com/pulumi/pulumi/pull/6006/files#diff-1fd47e1ff18121659c96a8f47296a2c0c715eb2662c64c7297fa0c5c1ad25c19R290, which changed deserialization of arrays into PropertyMaps from returning `nil` to returning empty arrays. Also adds additional logging in mustWrite. Fixes #6197.
pgavlin
approved these changes
Feb 22, 2021
|
Can we add some unit tests for this (or file a followup issue for the same)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using
reflect.DeepEqualto using PropertyMap'sDeepEqualsdirectly for Inputs and Outputs.This avoids issues with
reflect.DeepEqualtreatingniland empty arrays as non-equal. These appear to have been triggered recently by https://github.com/pulumi/pulumi/pull/6006/files#diff-1fd47e1ff18121659c96a8f47296a2c0c715eb2662c64c7297fa0c5c1ad25c19R290, which changed deserialization of arrays into PropertyMaps from returningnilto returning empty arrays.Also adds additional logging in mustWrite.
Fixes #6197.