[automation/nodejs] - Expose structured logging #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
force-pushed
the
komalali/automation-api-events
branch
from
daff9f6
to
9392c9f
Compare
komalali
changed the title
komalali
force-pushed
the
komalali/automation-api-events
branch
2 times, most recently
from
b364c1e
to
86da460
Compare
komalali
force-pushed
the
komalali/automation-api-events
branch
from
86da460
to
397a52b
Compare
lukehoban
approved these changes
Mar 10, 2021
| // Op is the operation being performed, a deploy.StepOp. | ||
| op: string; | ||
| urn: string; | ||
| type: string; |
There was a problem hiding this comment.
This may have been my doing in the original draft PR - but we likely want to make sure all the properties are documented here.
There was a problem hiding this comment.
I went through and did a second pass, the ones still missing don't have a description in common/apitype/events.
komalali
force-pushed
the
komalali/automation-api-events
branch
from
6ecc281
to
cf202c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #6436 for the go implementation.
Changes
onEventoption toStack.up(),Stack.preview(),Stack.refresh()andStack.destroy()for acting on structured json events.PreviewResultinterface to include achangeSummaryproperty that summarizes changes to resources.Fixes: #6442