[sdk/go] Simplify Apply method options to reduce binary size
#6607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
added
the
impact/breaking
leezen
reviewed
Mar 24, 2021
stack72
force-pushed
the
feature-3.0
branch
2 times, most recently
from
bc1e73a
to
9668cd2
Compare
stack72
force-pushed
the
lukehoban/removeapplytypename
branch
from
4eb61e0
to
85c05e4
Compare
|
@lukehoban I've rebased this for you based on the new feature-3.0 branch - this is a simpler merge now :D |
|
LGTM. Flaky tests in CI? Something shows as red. |
pgavlin
approved these changes
Mar 24, 2021
|
@t0yv0 yeah this is because of the new minVersionChecking that is breaking our CI tests |
stack72
force-pushed
the
feature-3.0
branch
3 times, most recently
from
6050cbe
to
72bf1b0
Compare
Reduces size for simple Kuberntes Go app from 131MB to 37.5MB - a 71% size reduction. Code that used `o.ApplyString(func(...)...)` must use `o.ApplyT(func(...)...).(StringOutput)` instead.
stack72
force-pushed
the
lukehoban/removeapplytypename
branch
from
85c05e4
to
7035c97
Compare
This was referenced Mar 24, 2021
stack72
pushed a commit
that referenced
this pull request
Mar 31, 2021
Co-authored-by: Komal <komal@pulumi.com>
viveklak
pushed a commit
that referenced
this pull request
Apr 3, 2021
Co-authored-by: Komal <komal@pulumi.com>
stack72
pushed a commit
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Komal <komal@pulumi.com>
stack72
pushed a commit
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Komal <komal@pulumi.com>
stack72
pushed a commit
that referenced
this pull request
Apr 13, 2021
Co-authored-by: Komal <komal@pulumi.com>
stack72
pushed a commit
that referenced
this pull request
Apr 14, 2021
Co-authored-by: Komal <komal@pulumi.com>
stack72
pushed a commit
that referenced
this pull request
Apr 14, 2021
Co-authored-by: Komal <komal@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Note: This PR is intended to be delivered as part of 3.0, and will be moved to target the
feature-3.0branch once that branch is up to date with master.]Make three breaking changes to the Pulumi Go SDK to (a) dramatically reduce the size and build-time for Pulumi Go programs and (b) simplify the options for
Applyin Go to offer a more consistent programming model.o.Apply<TypeName>(...)methods => useo.ApplyT(...)insteado.Apply(...)methods => useo.ApplyT(...)insteado.IsSecret()method => usepulumi.IsSecret(o)insteadFor a common Go program (the Pulumi Kubernetes Go template for example), this reduces binary size by 77% (from 131.2MB to 30.7MB).
These changes also reduce the options for
Applyin Pulumi's Go SDK from 3 options to just 1. Users will always useApplyT, and can express the type of the output they get from theApplyTcall as a type assertion. This was the most commonly used style in existing codebases, and is not the single standardized option. BothApplyandApply<TypeName>were previously thin sugar overApplyT- but that sugar led to confusion in the programming model, and significant unintended size increases.Fixes #6592.
Resolves #6356 (no longer necessary).
Resolves #6591 (addresses most sources of large binary size).