[codegen/go] Fix Go resource registrations

[justinvp]

We've been emitting calls to New<Resource> for resource registrations in Go, passing nil for args. However, some of those New<Resource> functions actually check for nil args and return an error if the resource has required arguments.

At first, I was looking for a way to check inside New<Resource> if the URN option was specified and in that case not error on nil args (like we do in other languages), but we don't provide a way to access the resource option values outside the Go SDK), so I don't think there is a way to do it this way for Go.

So instead, this change updates the registration code to call ctx.RegisterResource directly instead of New<Resource>, where we can pass a nil args.

Fixes pulumi/pulumi-eks#537

[github-actions]

Diff for pulumi-random with merge commit ce338d8

[github-actions]

Diff for pulumi-kubernetes with merge commit ce338d8

[github-actions]

Diff for pulumi-azuread with merge commit ce338d8

[github-actions]

Diff for pulumi-gcp with merge commit ce338d8

[lblackstone]

I confirmed that this fix worked by compiling new versions of pulumi-kubernetes, pulumi-eks, and pulumi-aws, and then running the following program:

package main

import (
	"os"

	"github.com/pulumi/pulumi-aws/sdk/v3/go/aws/iam"
	"github.com/pulumi/pulumi-eks/sdk/go/eks"
	"github.com/pulumi/pulumi/sdk/v2/go/pulumi"
)

func main() {
	pulumi.Run(func(ctx *pulumi.Context) error {

		eksCluster, err := eks.NewCluster(ctx, "eks-cluster", &eks.ClusterArgs{
			InstanceType:       pulumi.String("t2.medium"),
			DesiredCapacity:    pulumi.Int(1),
			MaxSize:            pulumi.Int(1),
			MinSize:            pulumi.Int(1),
			CreateOidcProvider: pulumi.Bool(true),
			ProviderCredentialOpts: &eks.KubeconfigOptionsArgs{
				ProfileName: pulumi.String(os.Getenv("AWS_PROFILE")),
			},
		})
		if err != nil {
			return err
		}

		oidcUrl := eksCluster.Core.OidcProvider().ApplyT(
			func(oidc *iam.OpenIdConnectProvider) pulumi.StringOutput { return oidc.Url })
		ctx.Export("oidcUrl", oidcUrl)

		return nil
	})
}

[github-actions]

Diff for pulumi-random with merge commit ce338d8

[github-actions]

Diff for pulumi-azuread with merge commit ce338d8

[github-actions]

Diff for pulumi-kubernetes with merge commit ce338d8

[justinvp]

Thanks for the help, @lblackstone!

[github-actions]

Diff for pulumi-gcp with merge commit ce338d8

[github-actions]

Diff for pulumi-azure with merge commit ce338d8

[github-actions]

Diff for pulumi-aws with merge commit ce338d8

[github-actions]

Diff for pulumi-azure-native with merge commit ce338d8

[bothra90]

Thanks for the fix, @justinvp!