[python/sdk] - Fix serialization bug if output contains 'items' property #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
force-pushed
the
komalali/fix-python-items-bug
branch
from
38e95ac
to
88441ce
Compare
justinvp
approved these changes
Apr 5, 2021
| @@ -169,10 +169,10 @@ def massage(attr: Any, seen: List[Any]): | |||
| # make sure this is a popo. | |||
| if isinstance(attr, dict): | |||
| result = {} | |||
| for key, value in attr.items(): | |||
| for key in attr: | |||
There was a problem hiding this comment.
Add a comment on why we're not using items() here, so we don't accidentally regress in the future?
komalali
force-pushed
the
komalali/fix-python-items-bug
branch
from
88441ce
to
b32db71
Compare
komalali
force-pushed
the
komalali/fix-python-items-bug
branch
from
b32db71
to
a323656
Compare
|
Lol just adding that comment has added 4 hours and counting to be able to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6697