-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet automation api ImportStackAsync and ExportStackAsync #6728
dotnet automation api ImportStackAsync and ExportStackAsync #6728
Conversation
CC @orionstudt |
TODO: PR against feature-3.0 to bring in compliance with #6415 that is pass --stack |
Thanks a ton for the review! I'm converging on shipping is for now as other methods don't have detailed Options yet either. @komalali ready for final review. |
Consider adding the methods to Something like: /// <summary>
/// Exports the deployment state of the stack.
/// <para/>
/// This can be combined with ImportStackAsync to edit a
/// stack's state (such as recovery from failed deployments).
/// </summary>
public Task<StackDeployment> ExportStackAsync(CancellationToken cancellationToken = default)
=> this.Workspace.ExportStackAsync(this.Name, cancellationToken);
/// <summary>
/// Imports the specified deployment state into a pre-existing stack.
/// <para/>
/// This can be combined with ExportStackAsync to edit a
/// stack's state (such as recovery from failed deployments).
/// </summary>
public Task ImportStackAsync(StackDeployment state, CancellationToken cancellationToken = default)
=> this.Workspace.ImportStackAsync(this.Name, state, cancellationToken); |
Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com>
Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com>
@komalali this should be good to review one last time (need a :stamp) and I can merge. |
Co-authored-by: Komal <komal@pulumi.com>
…ulumi#6728) * Initial impl of import/export * Add test * Address PR comments * Do not Select stack but pass it as --stack * Add CHANGELOG entry * Update sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com> * Update sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com> * Add helper methods to match node SDK * Match project settings * Update CHANGELOG_PENDING.md Co-authored-by: Komal <komal@pulumi.com> Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com> Co-authored-by: Komal <komal@pulumi.com>
Could't use Deplomyent as in node SDK as this is taken by something else. So StackDeployment. Good name?
Should I add show-secrets flag?
Do we want ImportOptions and ExportOptions with OnStandardError etc.