Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation/python] - Fix stack settings serialization #6776

Merged
merged 1 commit into from Apr 15, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Apr 15, 2021

Marking this no-changelog-required because we're in a weird in-between state and this will go out as a patch fix so the changelog will be added during release.

Changelog entry:

Bugfix:

  • [automation/python] - Fix serialization bug in StackSettings

@komalali komalali requested review from stack72 and leezen April 15, 2021 00:15
@komalali komalali added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 15, 2021
@stack72
Copy link
Contributor

stack72 commented Apr 15, 2021

This is going into master and then being cherry picked to a patch of v2.25.0 so we don’t need the changelog specifically in master right now

@komalali komalali force-pushed the komalali/python-stack-settings-fix branch 3 times, most recently from e471449 to 4f4589d Compare April 15, 2021 01:26
@komalali komalali force-pushed the komalali/python-stack-settings-fix branch 3 times, most recently from 8360061 to c90c2dd Compare April 15, 2021 17:19
@komalali komalali changed the base branch from master to 2.x-code-series April 15, 2021 17:19
@komalali komalali changed the base branch from 2.x-code-series to master April 15, 2021 17:24
@komalali komalali force-pushed the komalali/python-stack-settings-fix branch from c90c2dd to 727d2a6 Compare April 15, 2021 17:24
@komalali komalali merged commit 4dcc0d6 into master Apr 15, 2021
@komalali komalali deleted the komalali/python-stack-settings-fix branch April 15, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants