Clean the template dir if the remote has changed #6784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
svangordon-fruit
force-pushed
the
svg/clean-templates
branch
from
287ee06
to
f27c91d
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
/run-acceptance-tests |
|
Please view the results of the PR Build + Acceptance Tests Run Here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the remote of the
~/.pulumi/templatesrepo is different than the remote provided through theworkspace.pulumiTemplateGitRepository, remove that directory. Without this change, if the user has templates cached locally (extremely likely), the client will attempt to clone the directory in~/.pulumi; when that fails because the dir already exists, it will drop into thetemplatesdir and do a pull. This results in the client continuing to use the previous templates source, instead of the new one set bypulumiTemplateGitRepository.This change makes #6545 usable.