[automation/python] - Fix deserialization of UpdateSummary #6838
Conversation
komalali
changed the title
| @@ -88,7 +88,8 @@ def __init__(self, | |||
| self.version = version | |||
| self.config: ConfigMap = {} | |||
| for key in config: | |||
| self.config[key] = ConfigValue(**config[key]) | |||
| config_value = config[key] | |||
| self.config[key] = ConfigValue(value=config_value["value"], secret=config_value["secret"]) | |||
There was a problem hiding this comment.
What was the error message before, did config[key] pass some unexpected parameters? Are "value" and "secret" fields required and always present? Especially "secret"? If it's optional consider config_value.get("secret", None).
There was a problem hiding this comment.
Yeah, both secret and value are always present and required. Merged so we could get this in 3.1.
The error was TypeError: __init__() got an unexpected keyword argument 'objectValue' because when the config is a map or an array it includes objectValue which is the deserialized object. I think we probably ideally want to include that as a way of resolving #5506 - but for now for consistency with other SDKs, I've removed it.
There was a problem hiding this comment.
That's the right change then, thank you!!
Deserialization of config values in UpdateSummary was erroring when the config value is a map or array. This fixes the issue.
Fixes: #6809