-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automation/*] Add support for getting stack outputs using Workspace #6859
[automation/*] Add support for getting stack outputs using Workspace #6859
Conversation
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
Hey, @vipentti thanks for the PR! Re: python - you're on the right track. All of that to say:
|
/run-acceptance-tests |
Please view the results of the PR Build + Acceptance Tests Run Here |
Pylint errors in the test run are fixed in #6872 |
LGTM in general, but I would prefer naming it |
I'll add
This sounds reasonable. So for go, python and nodejs I'll rename |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
/run-acceptance-tests |
Please view the results of the PR Build + Acceptance Tests Run Here |
1 similar comment
Please view the results of the PR Build + Acceptance Tests Run Here |
This adds the ability to get the stack outputs using Workspace without having to first create or select a stack.
This was inspired by @komalali's awesome self-service-platyform, specifically these lines.
Regarding the Python implementation, since I'm less familiar with Python:
I'm not sure what is the correct way to avoid circular dependencies, specifically regarding
OutputMap
, so I figured the simplest way would be to moveOutputValue
andOutputMap
to a separate file_output.py
and then import them where necessary.I'm not sure if this considered a breaking change, which I would like to avoid. Based on my understanding the
OutputValue
andOutputMap
are not part of the public interface since they are not mentioned inautomation/__init__.py
variable__all__
.