Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auto/go] - Provide GetPermalink for all results #6875

Merged
merged 2 commits into from
Apr 27, 2021
Merged

[auto/go] - Provide GetPermalink for all results #6875

merged 2 commits into from
Apr 27, 2021

Conversation

elsesiy
Copy link
Contributor

@elsesiy elsesiy commented Apr 26, 2021 •
edited
Loading

Adds missing receiver funcs for GetPermalink to PreviewResult,RefreshResult,DestroyResult
Add simple test case
Update Changelog

Fix #6778

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

1 similar comment
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lukehoban lukehoban requested a review from komalali April 26, 2021 07:54
@lukehoban
Copy link
Member

/run-acceptance-tests on the PR

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@komalali komalali requested a review from EvanBoyle April 26, 2021 15:58
komalali
komalali reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @elsesiy! LGTM overall once you fix up the copyright preamble in the new test file.

sdk/go/auto/stack_test.go
@@ -0,0 +1,35 @@
package auto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will need the copyright preamble, or you can put this test in local_workspace_test.go - up to you :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komalali I added a modified version using the current year and fixed the conflicts, PTAL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

EvanBoyle
EvanBoyle approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for the contribution!

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@elsesiy
Provide GetPermalink for all results
07e4184 
Adds missing receiver funcs for GetPermalink to PreviewResult,RefreshResult,DestroyResult
Add simple test case
Update Changelog

Fix #6778
@elsesiy
Add copyright preamble
f01e299
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@komalali komalali changed the title Provide GetPermalink for all results [auto/go] - Provide GetPermalink for all results Apr 27, 2021
@komalali komalali merged commit 837f75f into pulumi:master Apr 27, 2021
@elsesiy elsesiy deleted the feat/6778-auto-permalink branch April 27, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBoyle EvanBoyle EvanBoyle approved these changes

@komalali komalali komalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Automation API] Expose Permalink for PreviewResult
4 participants
@elsesiy @lukehoban @EvanBoyle @komalali