-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automation/*] - Optionally skip Automation API version check #6882
Conversation
This commit adds an option to skip the minimal CLI version check for the automation API in Go. If `PULUMI_AUTOMATION_API_SKIP_VERSION_CHECK` has a non-empty value, the check is skipped. Fixes #6711 for Go only.
6e5db28
to
bf8e82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good! Nice work on adding this so fast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. One case with workspace envs that should probably be considered first.
Also, I'm not sure if we've been keeping up with this (we should be) but would be worth adding a godoc example https://github.com/pulumi/pulumi/blob/master/sdk/go/auto/example_test.go
…/pulumi#6882) Co-authored-by: James Nugent <jen20@apple.com>
This PR adds an option to skip the minimal CLI version check for Automation API . If
PULUMI_AUTOMATION_API_SKIP_VERSION_CHECK
has a non-empty value, the check is skipped.Docs PR: pulumi/pulumi-hugo#154
Fixes: #6711