Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation/*] - Optionally skip Automation API version check #6882

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Apr 27, 2021

This PR adds an option to skip the minimal CLI version check for Automation API . If PULUMI_AUTOMATION_API_SKIP_VERSION_CHECK has a non-empty value, the check is skipped.

Docs PR: pulumi/pulumi-hugo#154

Fixes: #6711

This commit adds an option to skip the minimal CLI version check for the
automation API in Go. If `PULUMI_AUTOMATION_API_SKIP_VERSION_CHECK` has
a non-empty value, the check is skipped.

Fixes #6711 for Go only.
@komalali komalali changed the title [automation/go] - Optionally skip Go automation API version check [automation/go] - Optionally skip Automation API version check Apr 27, 2021
@komalali komalali changed the title [automation/go] - Optionally skip Automation API version check [automation/*] - Optionally skip Automation API version check Apr 27, 2021
@komalali komalali requested a review from EvanBoyle April 27, 2021 04:01
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good! Nice work on adding this so fast

Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. One case with workspace envs that should probably be considered first.

Also, I'm not sure if we've been keeping up with this (we should be) but would be worth adding a godoc example https://github.com/pulumi/pulumi/blob/master/sdk/go/auto/example_test.go

sdk/go/auto/local_workspace.go Outdated Show resolved Hide resolved
@komalali komalali merged commit 1ed3445 into master Apr 28, 2021
@komalali komalali deleted the jen20automation branch April 28, 2021 03:54
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[automation/*] - Introduce env var to bypass min version checking
4 participants