-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk/nodejs|python] Add GetSchema support to providers #6892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89e751b
to
c6b5def
Compare
b4b9b8f
to
11d5e04
Compare
lukehoban
reviewed
May 6, 2021
Not sure what's going on with the test failure on Windows. Will look into it. |
e76d267
to
92db1e8
Compare
t0yv0
reviewed
May 12, 2021
@@ -147,6 +147,11 @@ export interface Provider { | |||
*/ | |||
version: string; | |||
|
|||
/** | |||
* The JSON-encoded schema for this provider's package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a great place to link to the meta-schema (the schema of the schema), if we have it.
🚢 love having schema available. We can build a lot of useful things on top. |
t0yv0
approved these changes
May 12, 2021
ce674c0
to
9acef4e
Compare
9acef4e
to
78f155a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6777