[cli] Ensure the user has set PULUMI_CONFIG_PASSPHRASE or PULUMI_CONFIG_PASSPHRASE_FILE #6893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
commented
Apr 27, 2021
| @@ -90,13 +90,6 @@ func newStackExportCmd() *cobra.Command { | |||
| } | |||
|
|
|||
| if showSecrets { | |||
| // Currently, the stack.DefaultSecretsProvider is cached so adding a call to getStackSecretsManager | |||
There was a problem hiding this comment.
Since this is now going to error properly, we can remove this workaround we added in this specific usecase
stack72
requested review from
komalali and
justinvp
and removed request for
komalali
justinvp
approved these changes
Apr 27, 2021
…IG_PASSPHRASE_FILE Fixes: #6286 When a user is using the passphrase provider and unsets the environment variables that let them interact with the secrets provider, then would get an error as follows: ``` ▶ pulumi up -y -f error: decrypting secret value: failed to decrypt: incorrect passphrase, please set PULUMI_CONFIG_PASSPHRASE to the correct passphrase ``` We are oging to change this error message to make it more obvious to a user what the error is and how they need to fix it ``` ▶ pulumi up -y -f error: constructing secrets manager of type "passphrase": unable to find either `PULUMI_CONFIG_PASSPHRASE` nor `PULUMI_CONFIG_PASSPHRASE_FILE` when trying to access the Passphrase Secrets Manager. Please ensure one of these values are set to allow the operation to continue ``` Ideally, we would like to prompt the user for the passphrase at this point rather than error, but the CLI could be in the middle of an update operation as the same codepath is used for reading stackreference values
stack72
force-pushed
the
prompt-for-passphrase
branch
from
5a168b8
to
a1a2ce9
Compare
lukehoban
reviewed
Apr 28, 2021
lukehoban
reviewed
Apr 28, 2021
stack72
added a commit
that referenced
this pull request
Apr 28, 2021
This incorporates some post merge feedback from #6893 This doesn't change the functionality of any of the tests: ``` go test -v ./secrets/passphrase -count=1 === RUN TestPassphraseManagerIncorrectPassphraseReturnsErrorCrypter --- PASS: TestPassphraseManagerIncorrectPassphraseReturnsErrorCrypter (0.89s) === RUN TestPassphraseManagerIncorrectStateReturnsError --- PASS: TestPassphraseManagerIncorrectStateReturnsError (0.00s) === RUN TestPassphraseManagerCorrectPassphraseReturnsSecretsManager --- PASS: TestPassphraseManagerCorrectPassphraseReturnsSecretsManager (1.08s) === RUN TestPassphraseManagerNoEnvironmentVariablesReturnsError --- PASS: TestPassphraseManagerNoEnvironmentVariablesReturnsError (0.00s) PASS ok github.com/pulumi/pulumi/pkg/v3/secrets/passphrase 2.270s ```
|
I've opened a further PR to address the comments by @lukehoban |
stack72
added a commit
that referenced
this pull request
Apr 28, 2021
This incorporates some post merge feedback from #6893 This doesn't change the functionality of any of the tests: ``` go test -v ./secrets/passphrase -count=1 === RUN TestPassphraseManagerIncorrectPassphraseReturnsErrorCrypter --- PASS: TestPassphraseManagerIncorrectPassphraseReturnsErrorCrypter (0.89s) === RUN TestPassphraseManagerIncorrectStateReturnsError --- PASS: TestPassphraseManagerIncorrectStateReturnsError (0.00s) === RUN TestPassphraseManagerCorrectPassphraseReturnsSecretsManager --- PASS: TestPassphraseManagerCorrectPassphraseReturnsSecretsManager (1.08s) === RUN TestPassphraseManagerNoEnvironmentVariablesReturnsError --- PASS: TestPassphraseManagerNoEnvironmentVariablesReturnsError (0.00s) PASS ok github.com/pulumi/pulumi/pkg/v3/secrets/passphrase 2.270s ```
stack72
added a commit
that referenced
this pull request
Apr 29, 2021
…ate (#6909) This incorporates some post merge feedback from #6893 This doesn't change the functionality of any of the tests: ``` go test -v ./secrets/passphrase -count=1 === RUN TestPassphraseManagerIncorrectPassphraseReturnsErrorCrypter --- PASS: TestPassphraseManagerIncorrectPassphraseReturnsErrorCrypter (0.89s) === RUN TestPassphraseManagerIncorrectStateReturnsError --- PASS: TestPassphraseManagerIncorrectStateReturnsError (0.00s) === RUN TestPassphraseManagerCorrectPassphraseReturnsSecretsManager --- PASS: TestPassphraseManagerCorrectPassphraseReturnsSecretsManager (1.08s) === RUN TestPassphraseManagerNoEnvironmentVariablesReturnsError --- PASS: TestPassphraseManagerNoEnvironmentVariablesReturnsError (0.00s) PASS ok github.com/pulumi/pulumi/pkg/v3/secrets/passphrase 2.270s ```
|
Hi @justinvp - we've just upgraded to this version and despite setting |
|
I got the same problem for not able to use pulumi because my |
|
Hey @lyenliang / @simonpinn I just opened a Pull request that will fix this up - this was not intended to remove support for "" You will still need to set PULUMI_CONFIG_PASSPHRASE as an "" but then it will work Please stay tuned for v3.2.1 release Paul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6286
When a user is using the passphrase provider and unsets the environment
variables that let them interact with the secrets provider, then would
get an error as follows:
We are oging to change this error message to make it more obvious
to a user what the error is and how they need to fix it
Ideally, we would like to prompt the user for the passphrase at this
point rather than error, but the CLI could be in the middle of an
update operation as the same codepath is used for reading stackreference
values