-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[auto/dotnet] - Add PulumiFn implementation for runtime stack type #6910
[auto/dotnet] - Add PulumiFn implementation for runtime stack type #6910
Conversation
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
…o the new PulumiFn implementation.
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
… the stack is instantiated each time because pulumi internal rely on instantiation
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
…t wasn't accounting for
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
Made a couple minor changes to make sure tests were passing. Should be good now. |
/run-acceptance-tests |
Looking great! Just had this one question above. |
Please view the results of the PR Build + Acceptance Tests Run Here |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
@t0yv0 FYI this is still waiting on merge, in case you missed it |
…ulumi/pulumi#6910) * add runtime stack type pulumi fn implementation * add exception propagation test and update changelog * slight refactor to just bring the identical service provider code into the new PulumiFn implementation. * get tests passing, need service to be registered as transient so that the stack is instantiated each time because pulumi internal rely on instantiation * check version command was failing because of additional white space it wasn't accounting for
Fixes #6898