Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto/dotnet] - Add PulumiFn implementation for runtime stack type #6910

Merged
merged 6 commits into from
May 10, 2021

Conversation

orionstudt
Copy link
Contributor

Fixes #6898

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@orionstudt
Copy link
Contributor Author

@t0yv0 @komalali this is ready for review whenever either of you have a moment. no hurry & ty!

… the stack is instantiated each time because pulumi internal rely on instantiation
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@orionstudt
Copy link
Contributor Author

Made a couple minor changes to make sure tests were passing. Should be good now.

@justinvp justinvp requested a review from t0yv0 April 29, 2021 18:50
@t0yv0
Copy link
Member

t0yv0 commented Apr 30, 2021

/run-acceptance-tests

@t0yv0
Copy link
Member

t0yv0 commented Apr 30, 2021

Looking great! Just had this one question above.

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@orionstudt
Copy link
Contributor Author

@t0yv0 FYI this is still waiting on merge, in case you missed it

@t0yv0 t0yv0 merged commit 31fec05 into pulumi:master May 10, 2021
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
…ulumi/pulumi#6910)

* add runtime stack type pulumi fn implementation

* add exception propagation test and update changelog

* slight refactor to just bring the identical service provider code into the new PulumiFn implementation.

* get tests passing, need service to be registered as transient so that the stack is instantiated each time because pulumi internal rely on instantiation

* check version command was failing because of additional white space it wasn't accounting for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PulumiFn.Create should support serviceType overload
2 participants