[auto/dotnet] Fix deserialization of CancelEvent in .NET 5 #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
/run-accceptance-tests |
t0yv0
approved these changes
May 19, 2021
@t0yv0 Small typo in the command so the acceptance tests were not actually run |
|
/run-acceptance-tests |
|
Please view the results of the PR Build + Acceptance Tests Run Here |
|
Thanks a ton for this 🚢 |
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
…lumi#7051) * [auto/dotnet] Fix deserialization of CancelEvent in .NET 5 * Update CHANGELOG_PENDING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7047
Checklist
Unfortunately the problem only happens when using .NET 5 so writing a suitable test currently is not possible afaik. I verified the change locally by using a minimal .NET 5 program and then calling
PreviewAsyncwith the providedOnEvent-callback. Without the change the same error occurs as described in #7047. With the change the deserialization works as expected.