[sdk/nodejs] Prevent Pulumi from overriding tsconfig.json options. #7068

swen128 · 2021-05-17T04:03:07Z

Description

Checklist

I have added tests that prove my fix is effective or that my feature works

I have updated the CHANGELOG-PENDING file with my change

I haven't added tests yet because I'm not sure which test directory is relevant with this PR (maybe /tests/integration ?).

github-actions · 2021-05-17T04:03:30Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions · 2021-05-17T04:04:47Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

sdk/nodejs/cmd/run-policy-pack/run.ts

lukehoban · 2021-05-24T00:13:22Z

Does this also address #3061?

lukehoban · 2021-05-24T00:15:20Z

I haven't added tests yet because I'm not sure which test directory is relevant with this PR (maybe /tests/integration ?).

@justinvp Any thoughts on this? I seem to recall us having some tests for the tsnode compilation and configuration, but can't see where they are currently.

lukehoban · 2021-05-24T01:51:56Z

sdk/nodejs/cmd/run-policy-pack/run.ts


    if (opts.typeScript) {
        tsnode.register({
            typeCheck: true,
-            skipProject: skipProject,
+            skipProject: true,
            compilerOptions: {
                target: "es6",


Note that since the default Pulumi templates use target: "es2016", this PR will lead to a change of beaviour for ~all users, where their tsnode compilation starts targeting es2016. I believe that should be fine (and indeed likely good). But it is a change, so we should be sure to do some further testing of this (for example, a run of the examples repo) to see if there are any issues raised.

Also related to pulumi/templates#116 which would involve bumping up the default target for new projects, which after this change would (correctly, I believe) cause those changes to get picked up by the tsnode compilation.

swen128 · 2021-05-24T10:45:41Z

Does this also address #3061?

pulumi/sdk/nodejs/cmd/run-policy-pack/run.ts

Lines 168 to 177 in 9abcca3

    
           tsnode.register({ 
        
               typeCheck: true, 
        
               skipProject: skipProject, 
        
               compilerOptions: { 
        
                   target: "es6", 
        
                   module: "commonjs", 
        
                   moduleResolution: "node", 
        
                   sourceMap: "true", 
        
               }, 
        
           });

This part does not override the paths option, so I doubt this is the cause of #3061.

github-actions · 2021-05-24T11:05:21Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

pgavlin

LGTM aside from @lukehoban's comments.

aviflax · 2021-06-18T18:57:47Z

I’m looking forward to this change! Just today I was frustrated that I couldn’t use Object.fromEntries which was just _exactly` what I needed. Kudos!

github-actions · 2021-08-02T15:46:51Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-02T15:49:03Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-05T16:33:45Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-13T13:11:17Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

justinvp · 2021-08-13T13:11:25Z

/run-acceptance-tests

github-actions · 2021-08-13T13:11:54Z

Please view the results of the PR Build + Acceptance Tests Run Here

github-actions · 2021-08-15T13:24:14Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-15T14:38:10Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

justinvp · 2021-08-15T14:38:18Z

/run-acceptance-tests

github-actions · 2021-08-15T14:38:47Z

Please view the results of the PR Build + Acceptance Tests Run Here

github-actions · 2021-08-15T15:29:24Z

Please view the results of the PR Build + Acceptance Tests Run Here

justinvp · 2021-08-16T01:58:18Z

LGTM. Thanks, @swen128! And many apologies for the delay getting this merged! I've included a test which confirms being able to set a new target compiler option from the program's tsconfig.json.

swen128 · 2021-08-16T07:19:26Z

@justinvp
Thanks for adding a test and merging this PR!

[sdk/nodejs] Prevent Pulumi from overriding tsconfig.json options.

f40ca9d

Update CHANGELOG_PENDING.md

6917ace

leezen requested review from justinvp and pgavlin May 19, 2021 02:58

lukehoban approved these changes May 24, 2021

View reviewed changes

sdk/nodejs/cmd/run-policy-pack/run.ts Show resolved Hide resolved

sdk/nodejs/cmd/run-policy-pack/run.ts Show resolved Hide resolved

lukehoban reviewed May 24, 2021

View reviewed changes

Fix skipProject option of tsnode.register

53dbcec

pgavlin approved these changes May 24, 2021

View reviewed changes

leezen added this to the 0.58 milestone Jun 7, 2021

emiliza modified the milestones: 0.58, 0.59 Jul 7, 2021

emiliza assigned justinvp Jul 26, 2021

emiliza modified the milestones: 0.59, 0.60 Jul 26, 2021

Merge branch 'master' into fix-ts-config

50465c7

Update CHANGELOG_PENDING.md

7d75989

Merge branch 'master' into fix-ts-config

935d560

Merge branch 'master' into fix-ts-config

293f450

Merge branch 'master' into fix-ts-config

95449bd

Add test

1d6f8f6

justinvp merged commit b5ee840 into pulumi:master Aug 16, 2021

justinvp mentioned this pull request Aug 16, 2021

Pulumi overrides tsconfig.json target #2673

Closed

swen128 deleted the fix-ts-config branch August 16, 2021 07:20

justinvp mentioned this pull request Sep 20, 2021

Update docs related to TypeScript pulumi/pulumi-hugo#612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sdk/nodejs] Prevent Pulumi from overriding tsconfig.json options. #7068

[sdk/nodejs] Prevent Pulumi from overriding tsconfig.json options. #7068

swen128 commented May 17, 2021 •

edited

Loading

github-actions bot commented May 17, 2021

github-actions bot commented May 17, 2021

lukehoban commented May 24, 2021

lukehoban commented May 24, 2021

lukehoban May 24, 2021

swen128 commented May 24, 2021

github-actions bot commented May 24, 2021

pgavlin left a comment

aviflax commented Jun 18, 2021

github-actions bot commented Aug 2, 2021

github-actions bot commented Aug 2, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Aug 13, 2021

justinvp commented Aug 13, 2021

github-actions bot commented Aug 13, 2021

github-actions bot commented Aug 15, 2021

github-actions bot commented Aug 15, 2021

justinvp commented Aug 15, 2021

github-actions bot commented Aug 15, 2021

github-actions bot commented Aug 15, 2021

justinvp commented Aug 16, 2021

swen128 commented Aug 16, 2021

[sdk/nodejs] Prevent Pulumi from overriding tsconfig.json options. #7068

[sdk/nodejs] Prevent Pulumi from overriding tsconfig.json options. #7068

Conversation

swen128 commented May 17, 2021 • edited Loading

Description

Checklist

github-actions bot commented May 17, 2021

github-actions bot commented May 17, 2021

lukehoban commented May 24, 2021

lukehoban commented May 24, 2021

lukehoban May 24, 2021

Choose a reason for hiding this comment

swen128 commented May 24, 2021

github-actions bot commented May 24, 2021

pgavlin left a comment

Choose a reason for hiding this comment

aviflax commented Jun 18, 2021

github-actions bot commented Aug 2, 2021

github-actions bot commented Aug 2, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Aug 13, 2021

justinvp commented Aug 13, 2021

github-actions bot commented Aug 13, 2021

github-actions bot commented Aug 15, 2021

github-actions bot commented Aug 15, 2021

justinvp commented Aug 15, 2021

github-actions bot commented Aug 15, 2021

github-actions bot commented Aug 15, 2021

justinvp commented Aug 16, 2021

swen128 commented Aug 16, 2021

swen128 commented May 17, 2021 •

edited

Loading