-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet/sdk] Support microsoft logging extensions with inline programs #7117
Conversation
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
1 similar comment
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
Example test output with these changes: `StackLifecycleInlineProgramWithServiceProvider` test output...
`InlineProgramExceptionPropagatesToCallerWithServiceProvider` test output...
|
@t0yv0 @orionstudt PTAL |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
@mikhailshilkov PTAL |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
/run-acceptance-tests |
BTW folks sorry for a long delay in review here, we had a company hackathon and that threw things off a bit at least for me. |
Please view the results of the PR Build + Acceptance Tests Run Here |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
Allright this is looking awesome! So Microsoft.Logging.Extensions seems just the thing for avoiding the API dependency we talked about. This is great. Unfortunately the Resharper PR landed so there are now conflicts. Would you be able to help resolve? If not I can try resolving but it will probably introduce more delays on this one. |
* Demystify serilog logger messages https://github.com/benaadams/Ben.Demystifier * Update changelog
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR Further commands available:
|
/run-acceptance-tests |
@t0yv0 Squashed, rebased and force pushed; ready for merge! |
Please view the results of the PR Build + Acceptance Tests Run Here |
Running tests once more, this should be it. |
…umi#7117) * Demystify serilog logger messages https://github.com/benaadams/Ben.Demystifier * Update changelog
Description
Fixes #7116.
Checklist