Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet/sdk] Support microsoft logging extensions with inline programs #7117

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented May 23, 2021

Description

Fixes #7116.

Checklist

  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

1 similar comment
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool
Copy link
Contributor Author

gitfool commented May 23, 2021

Example test output with these changes:

image

`StackLifecycleInlineProgramWithServiceProvider` test output...
[18:36:36 DBG] Creating deployment engine
[18:36:36 DBG] Created deployment engine
[18:36:36 DBG] Creating deployment monitor
[18:36:36 DBG] Created deployment monitor
[18:36:36 DBG] Registering task: Output<IDictionary<string, object>>
[18:36:36 DBG] Registering task: Output<ImmutableArray<Resource>>
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Fields to assign: ["exp_secret","exp_cfg","exp_static","urn"]
[18:36:36 DBG] Registering task: Fields to assign: ["exp_secret","exp_cfg","exp_static","urn"]
[18:36:36 DBG] Registering resource start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering task: Registering resource start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Preparing resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering task: Preparing resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering task: ReadOrRegisterResource: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Registering task: Output<string>
[18:36:36 DBG] Registering task: Output<IDictionary<string, object>>
[18:36:36 DBG] Registering task: RegisterResourceOutputs: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:36 DBG] Registering task: RunAsync: Pulumi.Automation.Tests.LocalWorkspaceTests+ValidStack
[18:36:36 DBG] Completed task: Output<IDictionary<string, object>>
[18:36:36 DBG] Completed task: Output<ImmutableArray<Resource>>
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: Output<IDictionary<string, object>>
[18:36:36 DBG] Completed task: RunAsync: Pulumi.Automation.Tests.LocalWorkspaceTests+ValidStack
[18:36:36 DBG] Prepared resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering task: Prepared resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering resource monitor start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering task: Registering resource monitor start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering resource monitor end: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Registering task: Registering resource monitor end: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: Fields to assign: ["exp_secret","exp_cfg","exp_static","urn"]
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: Output<string>
[18:36:36 DBG] Completed task: ReadOrRegisterResource: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:36 DBG] Completed task: Registering resource start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] Completed task: Preparing resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:36 DBG] RegisterResourceOutputs RPC prepared: urn=urn:pulumi:upqluaer::inline_serviceprovider_node::pulumi:pulumi:Stack::inline_serviceprovider_node-upqluaer
[18:36:36 DBG] Registering task: RegisterResourceOutputs RPC prepared: urn=urn:pulumi:upqluaer::inline_serviceprovider_node::pulumi:pulumi:Stack::inline_serviceprovider_node-upqluaer
[18:36:37 DBG] Completed task: RegisterResourceOutputs: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:37 DBG] Completed task: RegisterResourceOutputs RPC prepared: urn=urn:pulumi:upqluaer::inline_serviceprovider_node::pulumi:pulumi:Stack::inline_serviceprovider_node-upqluaer
[18:36:37 DBG] Completed task: Registering resource monitor end: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:37 DBG] Completed task: Registering resource monitor start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:37 DBG] Completed task: Prepared resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Creating deployment engine
[18:36:43 DBG] Created deployment engine
[18:36:43 DBG] Creating deployment monitor
[18:36:43 DBG] Created deployment monitor
[18:36:43 DBG] Registering task: Output<IDictionary<string, object>>
[18:36:43 DBG] Registering task: Output<ImmutableArray<Resource>>
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Fields to assign: ["exp_secret","exp_cfg","exp_static","urn"]
[18:36:43 DBG] Registering task: Fields to assign: ["exp_secret","exp_cfg","exp_static","urn"]
[18:36:43 DBG] Registering resource start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering task: Registering resource start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Preparing resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering task: Preparing resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering task: ReadOrRegisterResource: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Registering task: Output<string>
[18:36:43 DBG] Registering task: Output<IDictionary<string, object>>
[18:36:43 DBG] Registering task: RegisterResourceOutputs: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:43 DBG] Registering task: RunAsync: Pulumi.Automation.Tests.LocalWorkspaceTests+ValidStack
[18:36:43 DBG] Completed task: Output<IDictionary<string, object>>
[18:36:43 DBG] Completed task: Output<ImmutableArray<Resource>>
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] Completed task: Output<IDictionary<string, object>>
[18:36:43 DBG] Completed task: RunAsync: Pulumi.Automation.Tests.LocalWorkspaceTests+ValidStack
[18:36:43 DBG] Prepared resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering task: Prepared resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering resource monitor start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering task: Registering resource monitor start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering resource monitor end: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Registering task: Registering resource monitor end: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] RegisterResourceOutputs RPC prepared: urn=urn:pulumi:upqluaer::inline_serviceprovider_node::pulumi:pulumi:Stack::inline_serviceprovider_node-upqluaer
[18:36:43 DBG] Registering task: RegisterResourceOutputs RPC prepared: urn=urn:pulumi:upqluaer::inline_serviceprovider_node::pulumi:pulumi:Stack::inline_serviceprovider_node-upqluaer
[18:36:43 DBG] Completed task: RegisterResourceOutputs: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] Completed task: Output<string>
[18:36:43 DBG] Completed task: ReadOrRegisterResource: pulumi:pulumi:Stack-inline_serviceprovider_node-upqluaer
[18:36:43 DBG] Completed task: Fields to assign: ["exp_secret","exp_cfg","exp_static","urn"]
[18:36:43 DBG] Completed task: Registering resource start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Completed task: Preparing resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Completed task: Prepared resource: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Completed task: Registering resource monitor start: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Completed task: Registering resource monitor end: t=pulumi:pulumi:Stack, name=inline_serviceprovider_node-upqluaer, custom=False, remote=False
[18:36:43 DBG] Completed task: RegisterResourceOutputs RPC prepared: urn=urn:pulumi:upqluaer::inline_serviceprovider_node::pulumi:pulumi:Stack::inline_serviceprovider_node-upqluaer
`InlineProgramExceptionPropagatesToCallerWithServiceProvider` test output...
[18:44:38 DBG] Creating deployment engine
[18:44:38 DBG] Created deployment engine
[18:44:38 DBG] Creating deployment monitor
[18:44:38 DBG] Created deployment monitor
[18:44:38 DBG] Registering task: Output<IDictionary<string, object>>
[18:44:38 DBG] Registering task: Output<ImmutableArray<Resource>>
[18:44:38 DBG] Registering task: Output<string>
[18:44:38 DBG] Fields to assign: ["urn"]
[18:44:38 DBG] Registering task: Fields to assign: ["urn"]
[18:44:38 DBG] Registering resource start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering task: Registering resource start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Preparing resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering task: Preparing resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering task: ReadOrRegisterResource: pulumi:pulumi:Stack-exception_inline_serviceprovider_node-qemxzfar
[18:44:38 DBG] Prepared resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering task: Prepared resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering resource monitor start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering task: Registering resource monitor start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering resource monitor end: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 DBG] Registering task: Registering resource monitor end: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:38 ERR] Running program 'C:\Users\sfausett\AppData\Local\JetBrains\Installations\ReSharperPlatformVs16_ebb026de\TestRunner\netcoreapp2.0\ReSharperTestRunner64.dll' failed with an unhandled exception:
System.IO.FileNotFoundException: Unable to find the specified file.
   at new Pulumi.Automation.Tests.LocalWorkspaceTests+FileNotFoundStack() in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation.Tests/LocalWorkspaceTests.cs:line 1161
   at object RuntimeMethodHandle.InvokeMethod(object target, object[] arguments, Signature sig, bool constructor, bool wrapExceptions)
   at object System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, object[] parameters, CultureInfo culture)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitDisposeCache(ServiceCallSite transientCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Func<ServiceProviderEngineScope, object> Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.RealizeService(ServiceCallSite callSite)+(ServiceProviderEngineScope scope) => { } [0]
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope) x 2
   at object Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Task<ExceptionDispatchInfo> Pulumi.Automation.PulumiFnServiceProvider.InvokeAsync(IRunner runner, CancellationToken cancellationToken)+() => { } in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation/PulumiFn.ServiceProvider.cs:line 45
   at Task<int> Pulumi.Deployment+Runner.RunAsync<TStack>(Func<TStack> stackFactory) in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi/Deployment/Deployment.Runner.cs:line 51
[18:44:38 DBG] Registering task: Running program 'C:\Users\sfausett\AppData\Local\JetBrains\Installations\ReSharperPlatformVs16_ebb026de\TestRunner\netcoreapp2.0\ReSharperTestRunner64.dll' failed with an unhandled exception:
System.IO.FileNotFoundException: Unable to find the specified file.
   at new Pulumi.Automation.Tests.LocalWorkspaceTests+FileNotFoundStack() in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation.Tests/LocalWorkspaceTests.cs:line 1161
   at object RuntimeMethodHandle.InvokeMethod(object target, object[] arguments, Signature sig, bool constructor, bool wrapExceptions)
   at object System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, object[] parameters, CultureInfo culture)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitDisposeCache(ServiceCallSite transientCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Func<ServiceProviderEngineScope, object> Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.RealizeService(ServiceCallSite callSite)+(ServiceProviderEngineScope scope) => { } [0]
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope) x 2
   at object Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Task<ExceptionDispatchInfo> Pulumi.Automation.PulumiFnServiceProvider.InvokeAsync(IRunner runner, CancellationToken cancellationToken)+() => { } in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation/PulumiFn.ServiceProvider.cs:line 45
   at Task<int> Pulumi.Deployment+Runner.RunAsync<TStack>(Func<TStack> stackFactory) in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi/Deployment/Deployment.Runner.cs:line 51
[18:44:38 DBG] Returning from program after last error
[18:44:40 DBG] Creating deployment engine
[18:44:40 DBG] Created deployment engine
[18:44:40 DBG] Creating deployment monitor
[18:44:40 DBG] Created deployment monitor
[18:44:40 DBG] Registering task: Output<IDictionary<string, object>>
[18:44:40 DBG] Registering task: Output<ImmutableArray<Resource>>
[18:44:40 DBG] Registering task: Output<string>
[18:44:40 DBG] Fields to assign: ["urn"]
[18:44:40 DBG] Registering task: Fields to assign: ["urn"]
[18:44:40 DBG] Registering resource start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Registering task: Registering resource start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Preparing resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Registering task: Preparing resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Registering task: ReadOrRegisterResource: pulumi:pulumi:Stack-exception_inline_serviceprovider_node-qemxzfar
[18:44:40 DBG] Prepared resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Registering task: Prepared resource: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Registering resource monitor start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 DBG] Registering task: Registering resource monitor start: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:40 ERR] Running program 'C:\Users\sfausett\AppData\Local\JetBrains\Installations\ReSharperPlatformVs16_ebb026de\TestRunner\netcoreapp2.0\ReSharperTestRunner64.dll' failed with an unhandled exception:
System.IO.FileNotFoundException: Unable to find the specified file.
   at new Pulumi.Automation.Tests.LocalWorkspaceTests+FileNotFoundStack() in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation.Tests/LocalWorkspaceTests.cs:line 1161
   at object RuntimeMethodHandle.InvokeMethod(object target, object[] arguments, Signature sig, bool constructor, bool wrapExceptions)
   at object System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, object[] parameters, CultureInfo culture)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitDisposeCache(ServiceCallSite transientCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Func<ServiceProviderEngineScope, object> Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.RealizeService(ServiceCallSite callSite)+(ServiceProviderEngineScope scope) => { } [0]
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope) x 2
   at object Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Task<ExceptionDispatchInfo> Pulumi.Automation.PulumiFnServiceProvider.InvokeAsync(IRunner runner, CancellationToken cancellationToken)+() => { } in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation/PulumiFn.ServiceProvider.cs:line 45
   at Task<int> Pulumi.Deployment+Runner.RunAsync<TStack>(Func<TStack> stackFactory) in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi/Deployment/Deployment.Runner.cs:line 51
[18:44:40 DBG] Registering task: Running program 'C:\Users\sfausett\AppData\Local\JetBrains\Installations\ReSharperPlatformVs16_ebb026de\TestRunner\netcoreapp2.0\ReSharperTestRunner64.dll' failed with an unhandled exception:
System.IO.FileNotFoundException: Unable to find the specified file.
   at new Pulumi.Automation.Tests.LocalWorkspaceTests+FileNotFoundStack() in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation.Tests/LocalWorkspaceTests.cs:line 1161
   at object RuntimeMethodHandle.InvokeMethod(object target, object[] arguments, Signature sig, bool constructor, bool wrapExceptions)
   at object System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, object[] parameters, CultureInfo culture)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitDisposeCache(ServiceCallSite transientCallSite, RuntimeResolverContext context)
   at TResult Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Func<ServiceProviderEngineScope, object> Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.RealizeService(ServiceCallSite callSite)+(ServiceProviderEngineScope scope) => { } [0]
   at object Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope) x 2
   at object Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Task<ExceptionDispatchInfo> Pulumi.Automation.PulumiFnServiceProvider.InvokeAsync(IRunner runner, CancellationToken cancellationToken)+() => { } in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi.Automation/PulumiFn.ServiceProvider.cs:line 45
   at Task<int> Pulumi.Deployment+Runner.RunAsync<TStack>(Func<TStack> stackFactory) in D:/Devel/Repos/gitfool/pulumi/sdk/dotnet/Pulumi/Deployment/Deployment.Runner.cs:line 51
[18:44:41 DBG] Registering resource monitor end: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:41 DBG] Registering task: Registering resource monitor end: t=pulumi:pulumi:Stack, name=exception_inline_serviceprovider_node-qemxzfar, custom=False, remote=False
[18:44:41 DBG] Returning from program after last error

@gitfool
Copy link
Contributor Author

gitfool commented May 23, 2021

@t0yv0 @orionstudt PTAL

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool
Copy link
Contributor Author

gitfool commented May 31, 2021

@mikhailshilkov PTAL

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@t0yv0 t0yv0 self-requested a review June 4, 2021 14:17
@t0yv0
Copy link
Member

t0yv0 commented Jun 4, 2021

/run-acceptance-tests

@t0yv0
Copy link
Member

t0yv0 commented Jun 4, 2021

BTW folks sorry for a long delay in review here, we had a company hackathon and that threw things off a bit at least for me.

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Please view the results of the PR Build + Acceptance Tests Run Here

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@t0yv0 t0yv0 added this to the 0.58 milestone Jun 9, 2021
@t0yv0 t0yv0 added the size/S Estimated effort to complete (1-2 days). label Jun 9, 2021
@t0yv0
Copy link
Member

t0yv0 commented Jun 10, 2021

Allright this is looking awesome! So Microsoft.Logging.Extensions seems just the thing for avoiding the API dependency we talked about. This is great.

Unfortunately the Resharper PR landed so there are now conflicts. Would you be able to help resolve? If not I can try resolving but it will probably introduce more delays on this one.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool gitfool changed the title [dotnet/sdk] Support Serilog logger factory with inline programs [dotnet/sdk] Support microsoft logging extensions with inline programs Jun 10, 2021
@t0yv0
Copy link
Member

t0yv0 commented Jun 10, 2021

/run-acceptance-tests

@gitfool
Copy link
Contributor Author

gitfool commented Jun 10, 2021

@t0yv0 Squashed, rebased and force pushed; ready for merge!

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@t0yv0
Copy link
Member

t0yv0 commented Jun 10, 2021

Running tests once more, this should be it.

@t0yv0 t0yv0 merged commit 7820d2c into pulumi:master Jun 11, 2021
@gitfool gitfool deleted the gh7116 branch June 11, 2021 03:11
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dotnet/sdk] Support Serilog logger factory with inline programs
3 participants