[sdk/python] Ensure Output objects are not iterable #7288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although Output objects can never correct support iteration, Python will see the implementation of `__getitem__` and try to iterate the object, leading to an infinite loop. To prevent this, we need to explicitly implement __iter__ and make it return a TypeError to prevent iteration (and offer a useful error message). Fixes #5028.
justinvp
approved these changes
Jun 14, 2021
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
blarghmatey
added a commit
to mitodl/ol-infrastructure
that referenced
this pull request
Aug 3, 2021
- Pulumi removed support for iteration of `Output` objects due to infinite iteration problems [here](pulumi/pulumi#7288). This fixes our use of iterators for the IPv6 network blocks. - Remove KMS VPC endpoint for now as it adds more complexity, requiring assignment of a security group to manage access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
Outputobjects can never correctly support iteration, Python will see the implementation of__getitem__and try to iterate the object, leading to an infinite loop. To prevent this, we need to explicitly implement__iter__and make it return aTypeErrorto prevent iteration (and offer a useful error message).Fixes #5028.