Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/dotnet] - bug fix resources destroyed after exception thrown during inline program #7299

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[sdk/dotnet] - bug fix resources destroyed after exception thrown during inline program #7299

merged 2 commits into from
Jun 15, 2021

Conversation

orionstudt
Copy link
Contributor

Description

This resolves the issue of resources being destroyed after an exception is thrown during an inline program. The gRPC portion of the Automation API implementation is now correctly returning in the error case and the WorkspaceStack instance is now conditionally throwing the relevant exception if an inline exception is present, that way the correct exception bubbles up to the Automation API consumer.

Fixes #7050

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

1 similar comment
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@orionstudt orionstudt mentioned this pull request Jun 15, 2021
Closed
@t0yv0
Copy link
Member

t0yv0 commented Jun 15, 2021

/run-acceptance-tests

@t0yv0
Copy link
Member

t0yv0 commented Jun 15, 2021

Sorry for late review again, I'm finally catching up. This looks reasonable I'd like to understand the fix a little better though, left some questions! Thanks for the work!

@t0yv0
Copy link
Member

t0yv0 commented Jun 15, 2021

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@t0yv0
Copy link
Member

t0yv0 commented Jun 15, 2021

Confirming macos test failure unrelated, fix coming to master separately.

@t0yv0 t0yv0 self-requested a review June 15, 2021 22:17
t0yv0
t0yv0 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it. Thanks again for the work!

@t0yv0 t0yv0 merged commit 2f4d10d into pulumi:master Jun 15, 2021
@orionstudt
Copy link
Contributor Author

Thanks @t0yv0!

@orionstudt orionstudt deleted the dotnet/inline-exception-destroys-resources branch June 15, 2021 22:22
@gitfool
Copy link
Contributor

gitfool commented Jun 15, 2021

Thanks @orionstudt!

@orionstudt orionstudt mentioned this pull request Jun 16, 2021
Closed
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@orionstudt
[sdk/dotnet] - bug fix resources destroyed after exception thrown dur…
6351900 
…ing inline program (pulumi/pulumi#7299)

* resolve issue with resources being destroyed if an exception is thrown during an inline program dotnet sdk

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception thrown in stack results in resources marked for deletion
3 participants
@orionstudt @t0yv0 @gitfool