[sdk/go] Specify known when creating outputs for construct #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an input is an unknown value or contains unknowns, specify known = false when creating the output.
Provides a Random resource that can be used by languages that don't support dynamic providers but need a custom resource for tests, to avoid having to take a dependency on the pulumi-random provider.
t0yv0
reviewed
Jun 21, 2021
t0yv0
reviewed
Jun 21, 2021
| pathEnv := pathEnv(t, | ||
| filepath.Join("..", "testprovider"), | ||
| filepath.Join(testDir, test.componentDir)) | ||
| integration.ProgramTest(t, &integration.ProgramTestOptions{ |
There was a problem hiding this comment.
Cool. Interesting so this was just bowing up before the change, no need for extra asserts?
There was a problem hiding this comment.
Right. Before the change, in the case of the Go-based provider, the Apply inside the provider's component implementation will run because it thinks the value is known, which will panic and fail the test. With the fix, the Apply won't run because we properly pass along unknown, so no panic, and the test succeeds. I wasn't really sure if there was a better way to test this from an integration test.
t0yv0
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an input is an unknown value or contains unknowns, specify
falseforknownwhen creating the output.Added integration tests to ensure this is behaving as expected for all languages.
Fixes #7318