Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python module nesting #7353

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Fix python module nesting #7353

merged 4 commits into from
Jun 22, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Jun 22, 2021 •
edited
Loading

Description

Fixes #7118

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

Diff for pulumi-random with merge commit f890c7b

@github-actions
Copy link

Diff for pulumi-azuread with merge commit f890c7b

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit f890c7b

@komalali komalali requested a review from justinvp June 22, 2021 20:26
@github-actions
Copy link

Diff for pulumi-random with merge commit dfaec03

@github-actions
Copy link

Diff for pulumi-azuread with merge commit dfaec03

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit dfaec03

@github-actions
Copy link

Diff for pulumi-gcp with merge commit f890c7b

@github-actions
Copy link

Diff for pulumi-gcp with merge commit dfaec03

@github-actions
Copy link

Diff for pulumi-azure with merge commit f890c7b

@github-actions
Copy link

Diff for pulumi-azure with merge commit dfaec03

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit f890c7b

@github-actions
Copy link

Diff for pulumi-aws with merge commit f890c7b

@github-actions
Copy link

Diff for pulumi-aws with merge commit dfaec03

justinvp
justinvp approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit dfaec03

@github-actions
Copy link

Diff for pulumi-random with merge commit e7badf0

@github-actions
Copy link

Diff for pulumi-azuread with merge commit e7badf0

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit e7badf0

@github-actions
Copy link

Diff for pulumi-gcp with merge commit e7badf0

@github-actions
Copy link

Diff for pulumi-azure with merge commit e7badf0

@github-actions
Copy link

Diff for pulumi-aws with merge commit e7badf0

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit e7badf0

@komalali komalali merged commit 0f97a9b into master Jun 22, 2021
@komalali komalali deleted the komalali/7118 branch June 22, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python multi-lang schema lowering loses module structure
2 participants
@komalali @justinvp