[sdk/go] Support for calling methods #7437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
justinvp
commented
Jul 6, 2021
t0yv0
reviewed
Jul 7, 2021
t0yv0
reviewed
Jul 7, 2021
t0yv0
reviewed
Jul 7, 2021
t0yv0
reviewed
Jul 7, 2021
| func (ctx *Context) getOpts(t string, providers map[string]ProviderResource, opts *resourceOptions, remote bool, | ||
| ) (URN, []URN, bool, string, map[string]string, bool, ID, []string, []string, string, error) { | ||
| func (ctx *Context) getOpts(t string, provider ProviderResource, opts *resourceOptions, remote bool, | ||
| ) (URN, []URN, bool, string, map[string]string, bool, ID, []string, []string, error) { |
There was a problem hiding this comment.
10-tuples remind me of Haskell pain from previous job, sitting there counting out positions to the 7th argument during a 3am debugging session. Could we use a record to name the fields? I can undertake a separate PR 😅
|
Looks good to me, neat, consistent with the other things I've seen. Comments mostly nit-ty and an opportunity to educate me. Now, this only modifies the Go SDK client to the Engine to issue Calls, assume the impl of Calls is in separate PR? |
t0yv0
approved these changes
Jul 7, 2021
justinvp
force-pushed
the
justin/methods_calling_go
branch
from
2c0d692
to
5cf47b8
Compare
justinvp
force-pushed
the
justin/methods_calling_go
branch
from
5cf47b8
to
2dbc430
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for calling methods from Go.
Part of #7072