Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit To[ElementType]PtrOutput methods for go enum output types #7499

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Emit To[ElementType]PtrOutput methods for go enum output types #7499

merged 6 commits into from
Jul 13, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Jul 13, 2021 •
edited
Loading

Description

Fixes #7496

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@komalali komalali changed the title commit test changes Emit To[ElementType]PtrOutput methods for go enum output types Jul 13, 2021
@github-actions
Copy link

Diff for pulumi-random with merge commit 0384062

@github-actions
Copy link

Diff for pulumi-random with merge commit e1934c5

@github-actions
Copy link

Diff for pulumi-random with merge commit 6479fa3

@github-actions
Copy link

Diff for pulumi-random with merge commit e3c8704

@github-actions
Copy link

Diff for pulumi-random with merge commit 4d93e54

@komalali komalali requested a review from pgavlin July 13, 2021 15:38
pgavlin
pgavlin approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits; LGTM otherwise.

pkg/codegen/go/gen.go Outdated Show resolved Hide resolved
pkg/codegen/go/gen.go Outdated Show resolved Hide resolved
pkg/codegen/go/gen.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Diff for pulumi-random with merge commit 6842c7b

@komalali komalali merged commit 0e3665f into master Jul 13, 2021
@pulumi-bot pulumi-bot deleted the komalali/go-enums-redux branch July 13, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[codegen/go] - Emit To[Type]PtrOutput methods for enum output types
2 participants
@komalali @pgavlin