[sdk/go] Fix methods panic when marshaling self
#7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
commented
Jul 21, 2021
Comment on lines
+75
to
+77
| func (*Component) ElementType() reflect.Type { | ||
| return reflect.TypeOf((*Component)(nil)) | ||
| } |
There was a problem hiding this comment.
The test fails after adding this (making *Component implement pulumi.Input), and succeeds after the fix in context.go.
There was a problem hiding this comment.
Input is such a scary interface. I'm developing an irrational fear that I'm not sure what happens when we declare something an input. I need to work on making this specific :)
pgavlin
reviewed
Jul 21, 2021
pgavlin
approved these changes
Jul 21, 2021
t0yv0
approved these changes
Jul 21, 2021
Pass a valid `destType` to `marshalInput` to avoid panicing when the `self` resource is an `Input`.
justinvp
force-pushed
the
justin/method_go_self
branch
from
ba96310
to
809c057
Compare
justinvp
changed the title
selfself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a valid
destTypetomarshalInputto avoid panicing when theselfresource implementspulumi.Input.This issue would have been caught by testing the generated code, in addition to comparing it to what is expected.
Fixes #7603