Added support for custom naming of dynamic provider resource #7633

jancespivo · 2021-07-24T11:48:51Z

Description

Now there is not possible to change a name of dynamic provider resource without copying a code of the pulumi.sdk.python.lib.pulumi.dynamic.dynamic.Resource and changing the hard-coded name "pulumi-python:dynamic:Resource". I successfully uses this proposal to make it possible.

Usage:

class CustomResource(
   Resource, module="custom-provider", name="CustomResource"
):
   ...

Checklist

I have added tests that prove my fix is effective or that my feature works

I have updated the CHANGELOG-PENDING file with my change

Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

github-actions · 2021-07-24T11:49:13Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-07-24T11:53:38Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

lukehoban · 2021-07-25T23:19:39Z

Thanks for the PR! I believe this would address #3468. We likely want to add the same support for Node.js as well as part of any update here.

pgavlin

Can we add some tests for this as well? An integration test like tests/integration/dynamic/python should work. To add a test, you can just copy that folder to a new folder (e.g. tests/integration/dynamic/python-type-name) and add a new test method to tests/integration/integration_python_test.go, e.g. by copying and modifying the method for tests/integration/dynamic/python.

Please let me know if you need any more info on how to add a test!

@lukehoban I think that we can file a follow-up issue for Node.

sdk/python/lib/pulumi/dynamic/dynamic.py

github-actions · 2021-07-27T08:07:15Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-07-27T08:12:07Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

pgavlin

One nit, but LGTM otherwise!

sdk/python/lib/pulumi/dynamic/dynamic.py

github-actions · 2021-07-28T04:51:30Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-07-28T12:54:30Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

lukehoban · 2021-07-28T12:54:30Z

/run-acceptance-tests

github-actions · 2021-07-28T12:55:03Z

Please view the results of the PR Build + Acceptance Tests Run Here

github-actions · 2021-08-04T18:54:13Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-04T18:55:57Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-04T18:58:12Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-04T19:08:44Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-04T19:16:19Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

jancespivo · 2021-08-04T19:18:25Z

@pgavlin I've added a test. It is my first contribution in go and I don't know how to run tests. I've tried to run go test in the integration directory, but it print PASS regardless the new test should pass or not. Please help :) Thx

github-actions · 2021-08-04T19:21:30Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

pgavlin

One small set of suggestions for the test changes, but this looks great!

You can ensure that your test runs by running go test -tags=all -run TestCustomResourceTypeNameDynamicPython from within the tests/integration directory.

tests/integration/integration_python_test.go

github-actions · 2021-08-17T08:06:41Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

Co-authored-by: Pat Gavlin <pgavlin@gmail.com>

github-actions · 2021-08-17T08:19:40Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2021-08-17T08:50:55Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

emiliza · 2021-08-17T17:02:11Z

/run-acceptance-tests

github-actions · 2021-08-17T17:02:42Z

Please view the results of the PR Build + Acceptance Tests Run Here

github-actions · 2021-08-17T17:42:57Z

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

emiliza · 2021-08-17T17:51:39Z

/run-acceptance-tests

github-actions · 2021-08-17T17:52:11Z

Please view the results of the PR Build + Acceptance Tests Run Here

infin8x · 2021-09-16T00:03:59Z

@pgavlin @lukehoban it looks like this did indeed fix #3468 - shall I resolve it or is there more work tracked there?

11498: area/cli: removed checks for PULUMI_DISABLE_RESOURCE_REFERENCES in cli r=RobbieMcKinstry a=stefins Removed checks for `PULUMI_DISABLE_RESOURCE_REFERENCES` env in cli and engine Related to #11385  # Description  partially fixes #11385 (issue) ## Checklist  - [ ] I have added tests that prove my fix is effective or that my feature works  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  11873: [sdk/nodejs] - Add support for custom naming of dynamic provider resource r=RobbieMcKinstry a=Asamsig  # Description  Fixes #11856 Added two new optional constructor parameters to `pulumi.dynamic.Resource`, `module`, and `type`, which enables custom type naming of dynamic provider resources. Based on the Python implementation from [here](#7633). ### Before All dynamic provider resources would have the type `pulumi-nodejs:dynamic:Resource` ### After Usage: ```ts class CustomResource extends pulumi.dynamic.Resource { constructor (name: string, opts?: pulumi.ResourceOptions) { super(new DummyResourceProvider(), name, {}, opts, "custom-provider", "CustomResource") } } ``` Output: `pulumi-nodejs:dynamic/custom-provider:CustomResource` ## Checklist  - [x] I have added tests that prove my fix is effective or that my feature works  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  Co-authored-by: STEFIN <stefin@pm.me> Co-authored-by: Alexander Samsig <koresamsig@gmail.com>

11873: [sdk/nodejs] - Add support for custom naming of dynamic provider resource r=RobbieMcKinstry a=Asamsig  # Description  Fixes #11856 Added two new optional constructor parameters to `pulumi.dynamic.Resource`, `module`, and `type`, which enables custom type naming of dynamic provider resources. Based on the Python implementation from [here](#7633). ### Before All dynamic provider resources would have the type `pulumi-nodejs:dynamic:Resource` ### After Usage: ```ts class CustomResource extends pulumi.dynamic.Resource { constructor (name: string, opts?: pulumi.ResourceOptions) { super(new DummyResourceProvider(), name, {}, opts, "custom-provider", "CustomResource") } } ``` Output: `pulumi-nodejs:dynamic/custom-provider:CustomResource` ## Checklist  - [x] I have added tests that prove my fix is effective or that my feature works  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  Co-authored-by: Alexander Samsig <koresamsig@gmail.com>

lukehoban requested a review from pgavlin July 25, 2021 23:17

pgavlin requested changes Jul 26, 2021

View reviewed changes

sdk/python/lib/pulumi/dynamic/dynamic.py Outdated Show resolved Hide resolved

jancespivo force-pushed the python-dynamic-resource-naming branch from 4f0fcc8 to 41cb09c Compare July 27, 2021 08:11

pgavlin approved these changes Jul 27, 2021

View reviewed changes

sdk/python/lib/pulumi/dynamic/dynamic.py Outdated Show resolved Hide resolved

jancespivo force-pushed the python-dynamic-resource-naming branch from 56237a6 to e9efab1 Compare August 4, 2021 18:55

jancespivo force-pushed the python-dynamic-resource-naming branch from e9efab1 to 92656e4 Compare August 4, 2021 18:57

jancespivo force-pushed the python-dynamic-resource-naming branch from 92656e4 to 1ad23e5 Compare August 4, 2021 19:08

jancespivo force-pushed the python-dynamic-resource-naming branch from 1ad23e5 to a41f145 Compare August 4, 2021 19:15

emiliza assigned pgavlin Aug 6, 2021

emiliza added this to the 0.60 milestone Aug 6, 2021

pgavlin approved these changes Aug 10, 2021

View reviewed changes

tests/integration/integration_python_test.go Outdated Show resolved Hide resolved

emiliza modified the milestones: 0.60, 0.61 Aug 16, 2021

emiliza added the awaiting-feedback Blocked on input from the author label Aug 16, 2021

jancespivo and others added 7 commits August 17, 2021 10:15

Added support for custom naming of Dynamic Provider resource

8786bcd

Added dynamic/ namespace to dynamic resource type name

aba2bb6

Co-authored-by: Pat Gavlin <pgavlin@gmail.com>

Made code more pythonic

119850a

Update sdk/python/lib/pulumi/dynamic/dynamic.py

d749cb5

Co-authored-by: Pat Gavlin <pgavlin@gmail.com>

Added test

04bedf8

Changed CHANGELOG_PENDING.md

ed4e14a

Update tests/integration/integration_python_test.go

16df9b1

Co-authored-by: Pat Gavlin <pgavlin@gmail.com>

jancespivo force-pushed the python-dynamic-resource-naming branch from 249086a to 4b34aae Compare August 17, 2021 08:19

Fixed test

4897dba

jancespivo force-pushed the python-dynamic-resource-naming branch from 4b34aae to 4897dba Compare August 17, 2021 08:50

emiliza removed the awaiting-feedback Blocked on input from the author label Aug 17, 2021

Fixed typing

a4b2117

pgavlin merged commit e67334d into pulumi:master Aug 17, 2021

This was referenced Jan 13, 2023

Unable to assign unique name to Dynamic providers in Pulumi Python #3468

Open

Support for custom type naming of dynamic provider resource #11856

Closed

[sdk/nodejs] - Add support for custom naming of dynamic provider resource #11873

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for custom naming of dynamic provider resource #7633

Added support for custom naming of dynamic provider resource #7633

jancespivo commented Jul 24, 2021 •

edited

Loading

github-actions bot commented Jul 24, 2021

github-actions bot commented Jul 24, 2021

lukehoban commented Jul 25, 2021

pgavlin left a comment

github-actions bot commented Jul 27, 2021

github-actions bot commented Jul 27, 2021

pgavlin left a comment

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

lukehoban commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

jancespivo commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

pgavlin left a comment

github-actions bot commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

emiliza commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

emiliza commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

infin8x commented Sep 16, 2021

Added support for custom naming of dynamic provider resource #7633

Added support for custom naming of dynamic provider resource #7633

Conversation

jancespivo commented Jul 24, 2021 • edited Loading

Description

Checklist

github-actions bot commented Jul 24, 2021

github-actions bot commented Jul 24, 2021

lukehoban commented Jul 25, 2021

pgavlin left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 27, 2021

github-actions bot commented Jul 27, 2021

pgavlin left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

lukehoban commented Jul 28, 2021

github-actions bot commented Jul 28, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

jancespivo commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

pgavlin left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

emiliza commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

emiliza commented Aug 17, 2021

github-actions bot commented Aug 17, 2021

infin8x commented Sep 16, 2021

jancespivo commented Jul 24, 2021 •

edited

Loading