[backend/filestate] Allow pulumi stack ls to see all stacks regardless of passphrase
#7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess of passphrase The information exposed via `pulumi stack ls` does not require being able to decrypt state files, but the existing logic for `pulumi stack ls` with the filestate backend was to fully decrypt the state file anyway, silently skipping any stacks that could not be decrypted. This led to surprising results from `pulumi stack ls`. After these changes, `pulumi stack ls` with the filestate backend will list *all* stacks that are available. Notably, because there is no notion of "project" scoping in the fielstate backend (yet), `pulumi stack ls` will list all stacks independent of the project name. Fixes #4798.
pgavlin
approved these changes
Jul 27, 2021
stack72
approved these changes
Jul 27, 2021
jancespivo
pushed a commit
to jancespivo/pulumi
that referenced
this pull request
Aug 4, 2021
…ess of passphrase (pulumi#7660) * [backend/filestate] Allow `pulumi stack ls` to see all stacks regardless of passphrase The information exposed via `pulumi stack ls` does not require being able to decrypt state files, but the existing logic for `pulumi stack ls` with the filestate backend was to fully decrypt the state file anyway, silently skipping any stacks that could not be decrypted. This led to surprising results from `pulumi stack ls`. After these changes, `pulumi stack ls` with the filestate backend will list *all* stacks that are available. Notably, because there is no notion of "project" scoping in the fielstate backend (yet), `pulumi stack ls` will list all stacks independent of the project name. Fixes pulumi#4798.
jancespivo
pushed a commit
to jancespivo/pulumi
that referenced
this pull request
Aug 4, 2021
…ess of passphrase (pulumi#7660) * [backend/filestate] Allow `pulumi stack ls` to see all stacks regardless of passphrase The information exposed via `pulumi stack ls` does not require being able to decrypt state files, but the existing logic for `pulumi stack ls` with the filestate backend was to fully decrypt the state file anyway, silently skipping any stacks that could not be decrypted. This led to surprising results from `pulumi stack ls`. After these changes, `pulumi stack ls` with the filestate backend will list *all* stacks that are available. Notably, because there is no notion of "project" scoping in the fielstate backend (yet), `pulumi stack ls` will list all stacks independent of the project name. Fixes pulumi#4798.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information exposed via
pulumi stack lsdoes not require being able to decrypt state files, but the existing logic forpulumi stack lswith the filestate backend was to fully decrypt the state file anyway, silently skipping any stacks that could not be decrypted. This led to surprising results frompulumi stack ls.After these changes,
pulumi stack lswith the filestate backend will list all stacks that are available. Notably, because there is no notion of "project" scoping in the fielstate backend (yet),pulumi stack lswill list all stacks independent of the project name.Fixes #4798.