Update of CONTRIBUTING.md to reflect 3.0 changelog #7698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulumi 3.0 no longer supports NodeJS < v11.x
justinvp
approved these changes
Aug 3, 2021
CONTRIBUTING.md
Outdated
| @@ -9,7 +9,7 @@ For larger features, we'd appreciate it if you open a [new issue](https://github | |||
| To hack on Pulumi, you'll need to get a development environment set up. You'll want to install the following on your machine: | |||
|
|
|||
| - Go 1.16 | |||
| - NodeJS 10.X.X or later | |||
| - NodeJS 11.X.X or later | |||
There was a problem hiding this comment.
It's really 12 or later. 12 is the current Maintenance LTS version. https://nodejs.org/en/about/releases/
justinvp
added
the
impact/no-changelog-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md updated to require NodeJS v11.x rather than v10.x, as Pulumi 3.0 no longer supports the latter.