Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen/schema] Add a schema checker #7865

Merged
merged 2 commits into from
Aug 31, 2021
Merged

[codegen/schema] Add a schema checker #7865

merged 2 commits into from
Aug 31, 2021

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Aug 28, 2021

  • Change the schema package to report semantic errors as diagnostics
    rather than Go errors
  • Add a pulumi schema check command to the CLI for static checking of
    package schemas

The semantic checker can be extended in the future to add support for
target-specific checks.

@github-actions
Copy link

Diff for pulumi-random with merge commit 63fcb11

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 63fcb11

@github-actions
Copy link

Diff for pulumi-random with merge commit b954fea

@github-actions
Copy link

Diff for pulumi-azuread with merge commit b954fea

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 63fcb11

@github-actions
Copy link

Diff for pulumi-aws with merge commit 63fcb11

@github-actions
Copy link

Diff for pulumi-aws with merge commit b954fea

@github-actions
Copy link

Diff for pulumi-gcp with merge commit b954fea

@github-actions
Copy link

Diff for pulumi-azure with merge commit 63fcb11

@github-actions
Copy link

Diff for pulumi-azure with merge commit b954fea

Short: "Analyze package schemas",
Long: `Analyze package schemas

Subcommands of this command can be used to analyze Pulumi package schemas. This can be useful to check hand-authored
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the correct doc page for what this tool is about, adding a link can be very handy: https://www.pulumi.com/docs/guides/pulumi-packages/schema/

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through, LGTM, send those diags out.. 🚢

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would be nice to have a small harness that evaluates a test schema, and checks against an expected set of diagnostic errors. Seems necessary if we are going to expect the providers team (and eventually customers) to depend on the output of this tool.

@github-actions
Copy link

Diff for pulumi-random with merge commit 9375840

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 9375840

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 9375840

@github-actions
Copy link

Diff for pulumi-aws with merge commit 9375840

@github-actions
Copy link

Diff for pulumi-azure with merge commit 9375840

- Change the schema package to report semantic errors as diagnostics
  rather than Go errors
- Add a `pulumi schema check` command to the CLI for static checking of
  package schemas

The semantic checker can be extended in the future to add support for
target-specific checks.
@github-actions
Copy link

Diff for pulumi-random with merge commit ef98ec4

@github-actions
Copy link

Diff for pulumi-azuread with merge commit ef98ec4

@github-actions
Copy link

Diff for pulumi-gcp with merge commit ef98ec4

@github-actions
Copy link

Diff for pulumi-aws with merge commit ef98ec4

@github-actions
Copy link

Diff for pulumi-azure with merge commit ef98ec4

@github-actions
Copy link

Diff for pulumi-random with merge commit f341d55

@github-actions
Copy link

Diff for pulumi-azuread with merge commit f341d55

@github-actions
Copy link

Diff for pulumi-gcp with merge commit f341d55

@github-actions
Copy link

Diff for pulumi-aws with merge commit f341d55

@github-actions
Copy link

Diff for pulumi-azure with merge commit f341d55

@pgavlin pgavlin merged commit 76ee1b8 into master Aug 31, 2021
@pulumi-bot pulumi-bot deleted the pgavlin/schemaDiags branch August 31, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants