-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codegen/schema] Add a schema checker #7865
Conversation
Diff for pulumi-random with merge commit 63fcb11 |
Diff for pulumi-azuread with merge commit 63fcb11 |
Diff for pulumi-random with merge commit b954fea |
Diff for pulumi-azuread with merge commit b954fea |
Diff for pulumi-gcp with merge commit 63fcb11 |
Diff for pulumi-aws with merge commit 63fcb11 |
Diff for pulumi-aws with merge commit b954fea |
Diff for pulumi-gcp with merge commit b954fea |
Diff for pulumi-azure with merge commit 63fcb11 |
Diff for pulumi-azure with merge commit b954fea |
Short: "Analyze package schemas", | ||
Long: `Analyze package schemas | ||
|
||
Subcommands of this command can be used to analyze Pulumi package schemas. This can be useful to check hand-authored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the correct doc page for what this tool is about, adding a link can be very handy: https://www.pulumi.com/docs/guides/pulumi-packages/schema/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through, LGTM, send those diags out.. 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Would be nice to have a small harness that evaluates a test schema, and checks against an expected set of diagnostic errors. Seems necessary if we are going to expect the providers team (and eventually customers) to depend on the output of this tool.
d7bd9c5
to
e809c5a
Compare
Diff for pulumi-random with merge commit 9375840 |
Diff for pulumi-azuread with merge commit 9375840 |
Diff for pulumi-gcp with merge commit 9375840 |
Diff for pulumi-aws with merge commit 9375840 |
Diff for pulumi-azure with merge commit 9375840 |
- Change the schema package to report semantic errors as diagnostics rather than Go errors - Add a `pulumi schema check` command to the CLI for static checking of package schemas The semantic checker can be extended in the future to add support for target-specific checks.
e809c5a
to
9aaf84a
Compare
Diff for pulumi-random with merge commit ef98ec4 |
Diff for pulumi-azuread with merge commit ef98ec4 |
Diff for pulumi-gcp with merge commit ef98ec4 |
Diff for pulumi-aws with merge commit ef98ec4 |
Diff for pulumi-azure with merge commit ef98ec4 |
Diff for pulumi-random with merge commit f341d55 |
Diff for pulumi-azuread with merge commit f341d55 |
Diff for pulumi-gcp with merge commit f341d55 |
Diff for pulumi-aws with merge commit f341d55 |
Diff for pulumi-azure with merge commit f341d55 |
rather than Go errors
pulumi schema check
command to the CLI for static checking ofpackage schemas
The semantic checker can be extended in the future to add support for
target-specific checks.