Validate Name, Version and Enviroment #7896
Conversation
For the full path: Package.Name Package.Version Package.Property.Default
|
Diff for pulumi-azuread with merge commit f6d8dbd |
|
Diff for pulumi-random with merge commit f6d8dbd |
|
Diff for pulumi-kubernetes with merge commit f6d8dbd |
|
Diff for pulumi-gcp with merge commit f6d8dbd |
|
Diff for pulumi-aws with merge commit f6d8dbd |
|
Diff for pulumi-azure with merge commit f6d8dbd |
|
/run-acceptance-tests |
|
Please view the results of the PR Build + Acceptance Tests Run Here |
|
Diff for pulumi-random with merge commit c1f8446 |
|
Diff for pulumi-azuread with merge commit c1f8446 |
|
Diff for pulumi-kubernetes with merge commit c1f8446 |
|
Diff for pulumi-gcp with merge commit c1f8446 |
|
Diff for pulumi-random with merge commit 94aa4e9 |
|
Diff for pulumi-azuread with merge commit 94aa4e9 |
|
Diff for pulumi-kubernetes with merge commit 94aa4e9 |
|
Diff for pulumi-gcp with merge commit 94aa4e9 |
|
Diff for pulumi-random with merge commit 40cbeeb |
|
Diff for pulumi-azuread with merge commit 40cbeeb |
|
Diff for pulumi-kubernetes with merge commit 40cbeeb |
|
Diff for pulumi-gcp with merge commit 40cbeeb |
|
Diff for pulumi-aws with merge commit 40cbeeb |
|
Diff for pulumi-azure with merge commit 40cbeeb |
|
Diff for pulumi-random with merge commit 1315cb7 |
|
Diff for pulumi-azuread with merge commit ef0d228 |
|
Diff for pulumi-kubernetes with merge commit ef0d228 |
|
Diff for pulumi-aws with merge commit ef0d228 |
|
Diff for pulumi-gcp with merge commit ef0d228 |
|
Diff for pulumi-azure with merge commit ef0d228 |
pkg/cmd/pulumi/schema_check.go
Outdated
| if err == nil && len(diags) != 0 { | ||
| return errors.New("schema validation failed") |
There was a problem hiding this comment.
| if err == nil && len(diags) != 0 { | |
| return errors.New("schema validation failed") | |
| if err == nil && diags.HasErrors() { | |
| return errors.New("schema validation failed") |
There was a problem hiding this comment.
Looks like this change didn't get applied?
pkg/codegen/internal/test/testdata/output-funcs/getIntegrationRuntimeObjectMetadatum.json
Outdated
Show resolved
Hide resolved
|
Since Pat is already here taking a raincheck and I'm a bit underwater with reviews, will review tomorrow.. |
|
Diff for pulumi-azuread with merge commit 73f4b19 |
|
Diff for pulumi-random with merge commit 73f4b19 |
|
Diff for pulumi-kubernetes with merge commit 73f4b19 |
|
Diff for pulumi-aws with merge commit 73f4b19 |
|
Diff for pulumi-gcp with merge commit 73f4b19 |
|
Diff for pulumi-azure with merge commit 73f4b19 |
|
LGTM modulo Pat's comment, should the clause short-circuit on len(diags) = 0 or just errors? assuming there are warnings and errors. We should not stop if just warnings? Also. Related thought. This uses JSON schema meta-schema: Potentially the same could be accomplished by adding validation patterns http://json-schema.org/understanding-json-schema/reference/regular_expressions.html#example and riding on generic JSON schema validation checks. Don't wait though till that lands, check this in. |
|
Diff for pulumi-random with merge commit 0cd63e7 |
|
Diff for pulumi-azuread with merge commit 0cd63e7 |
|
Diff for pulumi-kubernetes with merge commit 0cd63e7 |
|
Diff for pulumi-aws with merge commit 0cd63e7 |
|
Diff for pulumi-gcp with merge commit 0cd63e7 |
|
Diff for pulumi-azure with merge commit 0cd63e7 |
Description
Adds validators for
Package.Name, corrects the validator forPackage.Version, and adds a validator forDefault.EnvironmentFixes #7893
Checklist