Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json.Unmarshal instead of custom parser #7954

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Use json.Unmarshal instead of custom parser #7954

merged 2 commits into from
Sep 13, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Sep 11, 2021 •
edited
Loading

Description

Use golang's native json.Unmarshal and tagged types instead of custom parsing with interface{}.

Fixes #7942

Checklist

  • I have added tests that prove my fix is effective or that my feature works
    Parsing json files is now handled by a library, and the library (go-std) does not need testing.
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Sep 11, 2021
@iwahbe iwahbe added the area/cli UX of using the CLI (args, output, logs) label Sep 11, 2021
justinvp
justinvp approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe iwahbe merged commit 3b7d78c into master Sep 13, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/7942/harden-about-input-parsing branch September 13, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@emiliza emiliza Awaiting requested review from emiliza

Assignees

@iwahbe iwahbe

Labels
area/cli UX of using the CLI (args, output, logs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running pulumi about results in panic -- "interface {} is nil, not string"
2 participants
@iwahbe @justinvp