Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/go] Emit input type registrations #7959

Merged
merged 4 commits into from
Oct 7, 2021
Merged

[codegen/go] Emit input type registrations #7959

merged 4 commits into from
Oct 7, 2021

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Sep 13, 2021 •
edited by pgavlin
Loading

Register an appropriate input type with the runtime for each object
type and composite thereof (e.g. pointer, array, etc.). This does not
cover registrations for enum and resource input types, which will be
added with future changes.

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 1d544ab

@github-actions
Copy link

Diff for pulumi-random with merge commit 1d544ab

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 1d544ab

@github-actions
Copy link

Diff for pulumi-aws with merge commit 1d544ab

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 1d544ab

@github-actions
Copy link

Diff for pulumi-azure with merge commit 1d544ab

@t0yv0 t0yv0 requested a review from a team September 22, 2021 16:19
@github-actions
Copy link

Diff for pulumi-azuread with merge commit 969b8b9

@github-actions
Copy link

Diff for pulumi-random with merge commit 969b8b9

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 969b8b9

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 969b8b9

@github-actions
Copy link

Diff for pulumi-azure with merge commit 969b8b9

@github-actions
Copy link

Diff for pulumi-aws with merge commit 969b8b9

@emiliza emiliza mentioned this pull request Oct 6, 2021
Closed
16 tasks
@emiliza emiliza added this to the 0.63 milestone Oct 6, 2021
@emiliza emiliza added area/component-packages aka multi-language components capacity/q421-mlc-ga labels Oct 6, 2021
This was referenced Oct 7, 2021
Closed
Closed
@pgavlin pgavlin force-pushed the justin/outputvalues_codegen branch from 0192ffa to 5cf175b Compare October 7, 2021 18:12
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit 98a3df2

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit 98a3df2

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit 98a3df2

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit 98a3df2

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit 44da232

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit 44da232

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit 44da232

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit 98a3df2

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit 44da232

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit 98a3df2

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit 44da232

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit 44da232

@pgavlin
Copy link
Member

pgavlin commented Oct 7, 2021

Looks like azure-native is still on an older version of github.com/pulumi/pulumi/sdk/v3, which is causing build failures in the generated code.

@pgavlin pgavlin requested a review from t0yv0 October 7, 2021 19:20
@emiliza emiliza requested a review from a team October 7, 2021 19:38
justinvp and others added 2 commits October 7, 2021 12:42
@justinvp @pgavlin
[codegen/go] Emit object input type registrations
e3b9574 
Register an appropriate input type with the runtime for each object
type and composite thereof (e.g. pointer, array, etc.). This does not
cover registrations for enum and resource input types, which will be
added with future changes.
@pgavlin
rebase
5393163
t0yv0
t0yv0 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pgavlin pgavlin force-pushed the justin/outputvalues_codegen branch from d62dceb to 7dca037 Compare October 7, 2021 19:43
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit b85eb2c

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit b85eb2c

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit b85eb2c

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit b85eb2c

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit b85eb2c

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit b85eb2c

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit 25c5f95

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit 25c5f95

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit 25c5f95

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit 25c5f95

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit 25c5f95

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit 25c5f95

@pgavlin pgavlin merged commit 789e392 into master Oct 7, 2021
@pulumi-bot pulumi-bot deleted the justin/outputvalues_codegen branch October 7, 2021 22:26
@emiliza emiliza added the size/S Estimated effort to complete (1-2 days). label Oct 8, 2021
@justinvp justinvp mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@pgavlin pgavlin pgavlin approved these changes

Assignees

@justinvp justinvp

Labels
area/component-packages aka multi-language components size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.63
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinvp @pgavlin @t0yv0 @emiliza