Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/go] - Resolve type name collisions #7985

Merged
merged 7 commits into from
Sep 23, 2021
Merged

[codegen/go] - Resolve type name collisions #7985

merged 7 commits into from
Sep 23, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Sep 16, 2021 •
edited
Loading

Description

Extends #7857 to include enums and fixes a regression in enum name collision detection

Fixes #7966

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-random with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-aws with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-azure with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 5353153

@github-actions
Copy link

Diff for pulumi-random with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-aws with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-azure with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 4915302

@github-actions
Copy link

Diff for pulumi-random with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-aws with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-azure with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 234b452

@github-actions
Copy link

Diff for pulumi-random with merge commit c648f79

@github-actions
Copy link

Diff for pulumi-azuread with merge commit c648f79

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit c648f79

@komalali komalali marked this pull request as ready for review September 17, 2021 21:39
@github-actions
Copy link

Diff for pulumi-gcp with merge commit c648f79

@github-actions
Copy link

Diff for pulumi-aws with merge commit c648f79

@github-actions
Copy link

Diff for pulumi-azure with merge commit c648f79

@github-actions
Copy link

Diff for pulumi-random with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 909ebef

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit e0a9e43

@github-actions
Copy link

Diff for pulumi-aws with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-azure with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit e393f9b

@komalali
Copy link
Member Author

komalali commented Sep 23, 2021 •
edited
Loading

omfg the merge conflicts 🤯

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 962ffad

@github-actions
Copy link

Diff for pulumi-random with merge commit 962ffad

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 04eb59b

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 962ffad

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 962ffad

@github-actions
Copy link

Diff for pulumi-aws with merge commit 962ffad

@github-actions
Copy link

Diff for pulumi-azure with merge commit 962ffad

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 962ffad

@komalali komalali merged commit b8b6f3d into master Sep 23, 2021
@komalali komalali deleted the komalali/type-collision branch September 23, 2021 22:42
@komalali komalali mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@pgavlin pgavlin pgavlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[codegen/go] - Regression in enum name generation
3 participants
@komalali @t0yv0 @pgavlin