Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Emit schema.Package.Version when possible (#7938)" #8035

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Revert "Emit schema.Package.Version when possible (#7938)" #8035

merged 3 commits into from
Sep 23, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Sep 23, 2021 •
edited
Loading

This reverts commit 906dce7.

Description

Revert try 2.

Fixes #8033

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe mentioned this pull request Sep 23, 2021
Closed
3 tasks
@github-actions
Copy link

Diff for pulumi-azuread with merge commit dca6a46

@github-actions
Copy link

Diff for pulumi-random with merge commit dca6a46

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit dca6a46

@github-actions
Copy link

Diff for pulumi-gcp with merge commit dca6a46

@iwahbe iwahbe requested a review from stack72 September 23, 2021 00:59
@github-actions
Copy link

Diff for pulumi-azuread with merge commit 3171ff8

komalali
komalali approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iwahbe !

@github-actions
Copy link

Diff for pulumi-random with merge commit 3171ff8

@github-actions
Copy link

Diff for pulumi-random with merge commit 0786ce8

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 0786ce8

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 3171ff8

@github-actions
Copy link

Diff for pulumi-aws with merge commit dca6a46

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 0786ce8

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 3171ff8

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 0786ce8

@github-actions
Copy link

Diff for pulumi-aws with merge commit 3171ff8

@github-actions
Copy link

Diff for pulumi-aws with merge commit 0786ce8

@github-actions
Copy link

Diff for pulumi-azure with merge commit dca6a46

@github-actions
Copy link

Diff for pulumi-azure with merge commit 3171ff8

@github-actions
Copy link

Diff for pulumi-azure with merge commit 0786ce8

@iwahbe
Copy link
Member Author

iwahbe commented Sep 23, 2021

azure-native Downstream unrelated. Merging.

@iwahbe iwahbe merged commit c9b719c into master Sep 23, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/8033/revert-7983 branch September 23, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalali komalali komalali approved these changes

@stack72 stack72 Awaiting requested review from stack72

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emitted SDK versions breaking provider builds
2 participants
@iwahbe @komalali