Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/nodejs] - Don't import types for functions if they don't exist #8038

Merged
merged 4 commits into from
Sep 23, 2021
Merged

[codegen/nodejs] - Don't import types for functions if they don't exist #8038

merged 4 commits into from
Sep 23, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Sep 23, 2021 •
edited
Loading

Description

Fixes #8037

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

Diff for pulumi-random with merge commit 81e2aca

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 81e2aca

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 81e2aca

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 81e2aca

@github-actions
Copy link

Diff for pulumi-aws with merge commit 81e2aca

@github-actions
Copy link

Diff for pulumi-azure with merge commit 81e2aca

@komalali komalali marked this pull request as ready for review September 23, 2021 04:31
@github-actions
Copy link

Diff for pulumi-azuread with merge commit 591e52b

@github-actions
Copy link

Diff for pulumi-random with merge commit 591e52b

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 591e52b

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 591e52b

@github-actions
Copy link

Diff for pulumi-aws with merge commit 591e52b

@github-actions
Copy link

Diff for pulumi-azure with merge commit 591e52b

@github-actions
Copy link

Diff for pulumi-random with merge commit e32a2ae

@github-actions
Copy link

Diff for pulumi-azuread with merge commit e32a2ae

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit e32a2ae

@github-actions
Copy link

Diff for pulumi-gcp with merge commit e32a2ae

@komalali komalali changed the title WIP - [codegen/nodejs] - Don't import types for functions if they don't exist [codegen/nodejs] - Don't import types for functions if they don't exist Sep 23, 2021
@github-actions
Copy link

Diff for pulumi-aws with merge commit e32a2ae

@github-actions
Copy link

Diff for pulumi-azure with merge commit e32a2ae

@komalali komalali requested review from stack72, a team, t0yv0 and pgavlin September 23, 2021 16:26
@komalali komalali merged commit 41b8882 into master Sep 23, 2021
@pulumi-bot pulumi-bot deleted the komalali/function-test branch September 23, 2021 17:12
@emiliza emiliza modified the milestone: 0.62 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@stack72 stack72 Awaiting requested review from stack72

@t0yv0 t0yv0 Awaiting requested review from t0yv0

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[codegen/nodejs] - Functions import types even when they don't exist
3 participants
@komalali @justinvp @emiliza