Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go automation API --target / --replace args #8109

Merged
merged 2 commits into from Oct 4, 2021
Merged

Fix Go automation API --target / --replace args #8109

merged 2 commits into from Oct 4, 2021

Conversation

jdartigalongue
Copy link
Contributor

@jdartigalongue jdartigalongue commented Oct 1, 2021

Description

This MR fixes an issue in the Pulumi Go automation API where --target / --replace args are not correctly formated, causing the CLI to not recognize the flag :

Error: unknown flag: --target urn:pulumi:stack::project::pulumi:providers:kubernetes::k8s

Fixes # (issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation
  • /run-containers - used to test the Pull Request against the containers tests

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation
  • /run-containers - used to test the Pull Request against the containers tests

@emiliza
Copy link
Contributor

emiliza commented Oct 1, 2021

/run-acceptance-tests

(Update: This run failed due to internal issues, need to re-trigger)

@emiliza
Copy link
Contributor

emiliza commented Oct 1, 2021

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Please view the results of the PR Build + Acceptance Tests Run Here

@emiliza emiliza requested a review from komalali October 4, 2021 16:11
@emiliza emiliza added this to the 0.63 milestone Oct 4, 2021
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jdartigalongue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants