Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimally extend .NET SDK to support 5758 #8142

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Oct 6, 2021

Description

The changes are mechanically taken out of #7899 and need to ship and propagate to SDKs before #7899 can succeed on the downstream checks. #7899 carries tests that exercise this functionality including dependency handling and pass.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@t0yv0 t0yv0 requested review from a team and mikhailshilkov October 6, 2021 15:27
@t0yv0 t0yv0 marked this pull request as ready for review October 6, 2021 15:27
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 6, 2021

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Please view the results of the PR Build + Acceptance Tests Run Here

<param name="version">The version of the plugin e.g. "v1.0.0".</param>
<param name="kind">The kind of plugin e.g. "resource".</param>
<param name="cancellationToken">A cancellation token.</param>
</member>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why we keep this file in source control?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a mistake to keep it. I'll follow up with PR to remove.

@t0yv0 t0yv0 merged commit 32695f7 into master Oct 7, 2021
@pulumi-bot pulumi-bot deleted the t0yv0/dotnet-sdk-support-for-5758-take-2 branch October 7, 2021 13:51
@emiliza emiliza added this to the 0.63 milestone Oct 7, 2021
@emiliza emiliza added capacity/q421-fn-outputs kind/task Work that's part of an ongoing epic size/S Estimated effort to complete (1-2 days). labels Oct 7, 2021
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
* Minimally extend .NET SDK to support 5758

* Retract CodegenUtilities

* Add CHANGELOG_PENDING
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Work that's part of an ongoing epic size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants