Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iwahbe/8000/uprgade go versions #8171

Merged
merged 6 commits into from
Oct 11, 2021
Merged

Iwahbe/8000/uprgade go versions #8171

merged 6 commits into from
Oct 11, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 7, 2021 •
edited
Loading

Description

Fixes #8000

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit f27d584

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit f27d584

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit a21219b

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit a21219b

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit f27d584

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit a21219b

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit f27d584

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit a21219b

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit f27d584

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit f27d584

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit a21219b

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit a21219b

@pulumi-bot pulumi-bot mentioned this pull request Oct 7, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit 300e5ff

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit 300e5ff

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit 300e5ff

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit 300e5ff

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit 300e5ff

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit 300e5ff

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure-native with merge commit a21219b

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure-native with merge commit f27d584

@iwahbe iwahbe requested review from emiliza and a team October 7, 2021 20:03
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure-native with merge commit 300e5ff

t0yv0
t0yv0 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but have we tested? I'm finding that some of these workflows we can only test after merging to master.

Copying @jkodroff perhaps has some wisdom for us here.

komalali
komalali requested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update sdk/go.mod and tests/go.mod too

@t0yv0
Copy link
Member

t0yv0 commented Oct 7, 2021 

git ls-files | grep go.mod | wc -l
35

Good catch. Unfortunately there's a lot of these --^

@komalali
Copy link
Member

komalali commented Oct 7, 2021

The rest don't really matter I'd argue as they are test cases and we support go 1.14+ (and the developer docs which don't have anything to do with go really) but sdk and tests certainly need updating.

@pgavlin
Copy link
Member

pgavlin commented Oct 7, 2021

The rest don't really matter I'd argue as they are test cases and we support go 1.14+

I might even go the other way and say that we want to leave the test-cases as-is for exactly this reason.

@iwahbe iwahbe requested a review from komalali October 7, 2021 22:39
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-random with merge commit a3792ec

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azuread with merge commit a3792ec

@iwahbe
Copy link
Member Author

iwahbe commented Oct 7, 2021

Go promises that if it runs on 1.14 then it should run on 1.17, so I'm inclined to agree with pgavlin.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-kubernetes with merge commit a3792ec

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-gcp with merge commit a3792ec

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-aws with merge commit a3792ec

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Diff for pulumi-azure with merge commit a3792ec

@iwahbe iwahbe merged commit 20287af into master Oct 11, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/8000/uprgade-go-versions branch October 11, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@komalali komalali komalali approved these changes

@emiliza emiliza Awaiting requested review from emiliza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.17
4 participants
@iwahbe @t0yv0 @komalali @pgavlin