Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine secretness by checking raw string for the secret sentinel #8179

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Determine secretness by checking raw string for the secret sentinel #8179

merged 3 commits into from
Oct 8, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Oct 8, 2021 •
edited
Loading

Description

Fixes #8170

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

lblackstone
lblackstone approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Thanks for the quick turnaround on this!

@komalali komalali merged commit a9a62bd into master Oct 8, 2021
@komalali komalali deleted the komalali/leaky-secrets-auto-api branch October 8, 2021 21:43
@komalali komalali mentioned this pull request Oct 28, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveklak viveklak viveklak approved these changes

@pgavlin pgavlin pgavlin approved these changes

@EvanBoyle EvanBoyle EvanBoyle approved these changes

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[auto/go] Secret annotation in automation API is inconsistent with CLI behavior
5 participants
@komalali @viveklak @pgavlin @EvanBoyle @lblackstone