Fix default package name #8187
Fix default package name #8187
Conversation
| name | importBasePath | rootPackageName | resulting root | resulting name | |:-------------:|:-----------------------------------------------------:|:---------------:|----------------|:---------------------------------:| | `hello-world` | ` ` | ` ` | `hello-world` | `helloworld` | | `hello-world` | `github.com/org/my-pulumi-package-aws-thing/my-thing` | ` ` | `mything` | `mything` | | `hello-world` | `github.com/org/my-pulumi-package-aws-thing/thing` | `bar` | ` ` | `bar` (and the package is flat) | | ` ` | `github.com/org/my-pulumi-package-aws-thing/thing` | `bar` | ` ` | `bar` (and the package is flat) | | `hello-world` | ` ` | `bar` | ` ` | `bar` (and the package is flat) | | ` ` | ` ` | `bar` | ` ` | `bar` (and the package is flat) |
|
Diff for pulumi-azuread with merge commit 98cef56 |
|
Diff for pulumi-random with merge commit 98cef56 |
|
Diff for pulumi-azuread with merge commit 72f9d34 |
|
Diff for pulumi-kubernetes with merge commit 98cef56 |
|
Diff for pulumi-random with merge commit 72f9d34 |
|
Diff for pulumi-gcp with merge commit 98cef56 |
|
Diff for pulumi-gcp with merge commit 72f9d34 |
|
Diff for pulumi-kubernetes with merge commit 72f9d34 |
|
Diff for pulumi-aws with merge commit 98cef56 |
|
Diff for pulumi-azure with merge commit 98cef56 |
|
Diff for pulumi-aws with merge commit 72f9d34 |
|
Diff for pulumi-azure with merge commit 72f9d34 |
|
Diff for pulumi-azuread with merge commit d2118f0 |
|
Diff for pulumi-random with merge commit d2118f0 |
|
Diff for pulumi-kubernetes with merge commit d2118f0 |
|
Diff for pulumi-gcp with merge commit d2118f0 |
|
Diff for pulumi-azure with merge commit d2118f0 |
|
Diff for pulumi-aws with merge commit d2118f0 |
|
Diff for pulumi-azure-native with merge commit d2118f0 |
| @@ -50,8 +50,8 @@ func TestInputUsage(t *testing.T) { | |||
|
|
|||
| func TestGoPackageName(t *testing.T) { | |||
| assert.Equal(t, "aws", goPackage("aws")) | |||
| assert.Equal(t, "azure", goPackage("azure-nextgen")) | |||
| assert.Equal(t, "plant", goPackage("plant-provider")) | |||
| assert.Equal(t, "azurenextgen", goPackage("azure-nextgen")) | |||
There was a problem hiding this comment.
Do we know what effect (if any) this change will have on azure-native and aws-native?
There was a problem hiding this comment.
Looks like they don't include the -native anyway:
"go": {
"importBasePath": "github.com/pulumi/pulumi-aws-native/sdk/go/aws",
"packageImportAliases": {
"github.com/pulumi/pulumi-aws-native/sdk/go/aws/aws-native": "aws"
}
},
There was a problem hiding this comment.
I believe that packageImportAliases went unused. We defaulted to getting the name from the name field, and we took strings.Split("aws-native", "-")[0] == "aws". In the new world we take path.Base("github.com/pulumi/pulumi-aws-native/sdk/go/aws") == "aws". This is the same as for azure.
pulumi-bot
deleted the
iwahbe/8181/go-improve-hyphenated-package-name-handling
branch
|
@iwahbe I'm not sure this is going to work all the way through codegen. I just tried changing the importBasepPath in https://github.com/pulumi/pulumi/blob/master/pkg/codegen/internal/test/testdata/simple-enum-schema/schema.json#L250 to |
|
We assume that the last segment of |
Resulting behavior:
hello-worldhello-worldhelloworldhello-worldgithub.com/org/my-pulumi-package-aws-thing/my-thingmythingmythinghello-worldgithub.com/org/my-pulumi-package-aws-thing/thingbarbargithub.com/org/my-pulumi-package-aws-thing/thingbarbarhello-worldbarbarbarbarDescription
Corrects the default behavior for deriving package names from the
name,importBasePathandrootPackageName.Fixes #8181
Checklist