[cli] Emit JSON events for updates via --json flag
#8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Oct 20, 2021
komalali
force-pushed
the
komalali/json
branch
2 times, most recently
from
ed8a13f
to
75f7303
Compare
pgavlin
reviewed
Oct 26, 2021
| @@ -169,7 +171,7 @@ func newDestroyCmd() *cobra.Command { | |||
| Scopes: cancellationScopes, | |||
| }) | |||
|
|
|||
| if res == nil && len(*targets) == 0 { | |||
| if res == nil && len(*targets) == 0 && !jsonDisplay { | |||
pgavlin
reviewed
Oct 26, 2021
|
|
||
| return encoder.Encode(apiEvent) | ||
| } | ||
|
|
||
| func startEventLogger(events <-chan engine.Event, done chan<- bool, opts Options) (<-chan engine.Event, chan<- bool) { |
There was a problem hiding this comment.
How does --json interact with the event logger? I'm guessing from the way things are factored that they will work together just fine.
There was a problem hiding this comment.
Yeah they work together just fine, and in fact the test uses the event log to ensure all events from the event log are present in the stdout output.
pgavlin
approved these changes
Oct 26, 2021
komalali
force-pushed
the
komalali/json
branch
from
75f7303
to
071515a
Compare
|
This feature is especially important for Automation API when you want to customize the output. No need to parse text. |
|
@komalali Pardon my ignorance to properly do the research. Thanks for the information! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
--jsonflag toup,destroyandrefreshand streams json events to stdout when the flag is passed.For
preview, the existing functionality of outputting a JSON object at the end of preview is maintained. However, the streaming output can be extended topreviewby using thePULUMI_ENABLE_STREAMING_JSON_PREVIEWenvironment variable.I added some tests, ready for review.
Follow-up Work
Fixes #2390
Checklist