Fix race condition in TaskMonitoringHelper #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8163 TaskMonitoringHelper was using two seperate trackers for Idle and FirstException and then calling WhenAny on both to see which state happened first. This was racy as you could end up completing a task with an exception but getting the idle tracker fire first, resulting in TaskMonitoringHelper thinking no exception had happened. I've combined the two trackers into TaskMonitoringHelper now. At each task completion we check for exceptions and then idleness.
pgavlin
approved these changes
Oct 26, 2021
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
* Fix race condition in TaskMonitoringHelper Fixes pulumi/pulumi#8163 TaskMonitoringHelper was using two seperate trackers for Idle and FirstException and then calling WhenAny on both to see which state happened first. This was racy as you could end up completing a task with an exception but getting the idle tracker fire first, resulting in TaskMonitoringHelper thinking no exception had happened. I've combined the two trackers into TaskMonitoringHelper now. At each task completion we check for exceptions and then idleness. * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8163
TaskMonitoringHelper was using two seperate trackers for Idle and
FirstException and then calling WhenAny on both to see which state
happened first. This was racy as you could end up completing a task with
an exception but getting the idle tracker fire first, resulting in
TaskMonitoringHelper thinking no exception had happened.
I've combined the two trackers into TaskMonitoringHelper now. At each
task completion we check for exceptions and then idleness.