-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[auto/python] - Fix deserialization of event #8375
[auto/python] - Fix deserialization of event #8375
Conversation
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
/run-acceptance-tests |
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Komal!
Please view the results of the PR Build + Acceptance Tests Run Here |
Description
Fixes the deserialization for the
metadata
property onResourcePreEvent
,ResOutputsEvent
andResOpFailedEvent
. There are no existing tests for the deserialization of engine events, so I haven't added any but this fixes my issue locally.Checklist