Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update command respects --target-dependents #8395

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Update command respects --target-dependents #8395

merged 9 commits into from
Nov 17, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 10, 2021 •
edited
Loading

This change enables pulumi up -t ${URN} --target-dependents. Previously --target-dependents was ignored for non destroy operations.

Description

Fixes #8209
Fixes #5869

Checklist

  • I have added tests that prove my fix is effective or that my feature works
    Tests are located in pkg/engine/lifeycletest/target_test.go as part of TestUpdateTarget.
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Nov 10, 2021
@iwahbe iwahbe marked this pull request as draft November 10, 2021 01:47
@iwahbe iwahbe requested review from pgavlin and a team November 10, 2021 01:50
@iwahbe iwahbe marked this pull request as ready for review November 10, 2021 18:54
@iwahbe iwahbe added the area/cli UX of using the CLI (args, output, logs) label Nov 13, 2021
@emiliza emiliza requested a review from t0yv0 November 15, 2021 17:17
@t0yv0
Copy link
Member

t0yv0 commented Nov 15, 2021

High-level tests for the feature please, could also explore if this obeys transitive deps in those tests...

I do realize you may be seeking some preliminary feedback on the approach from Pat before doing the tests, that's great, can wait. Just given my level of familiarity tests do help reviewing a lot. Thanks.

@iwahbe iwahbe requested review from t0yv0 and pgavlin November 16, 2021 22:26
pgavlin
pgavlin approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise!

@iwahbe iwahbe merged commit 3329d81 into master Nov 17, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/8209/update-respect-target-dependents branch November 17, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

Assignees

@iwahbe iwahbe

Labels
area/cli UX of using the CLI (args, output, logs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target dependencies doesn't update dependents pulumi up --target doesn't support create dependent targets
3 participants
@iwahbe @t0yv0 @pgavlin