Add tests that return failures from Call #8424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation It's useful to be able to not specify any outputs when returning failures from Call.
2 tasks
t0yv0
reviewed
Nov 16, 2021
| const deps = new provproto.CallResponse.ReturnDependencies(); | ||
| deps.setUrnsList(await Promise.all(Array.from(resources).map(r => r.urn.promise()))); | ||
| returnDependenciesMap.set(key, deps); | ||
| if (result.outputs) { |
There was a problem hiding this comment.
In case result.outputs is falsey, we don't need to resp.setReturn()? Use default value?
t0yv0
reviewed
Nov 16, 2021
| @@ -20,6 +20,12 @@ | |||
| - [sdk/nodejs] - Unmarshal output values in component provider. | |||
| [#8205](https://github.com/pulumi/pulumi/pull/8205) | |||
|
|
|||
| - [sdk/nodejs] - Allow returning failures from Call in the provider without setting result outputs. | |||
t0yv0
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some integration tests that return failures from
Call, addressing a couple issues found in the process:Fixes #7649