Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/pthon] Version Check: Handle virtual env correctly #8465

Merged
merged 4 commits into from
Nov 19, 2021
Merged

[sdk/pthon] Version Check: Handle virtual env correctly #8465

merged 4 commits into from
Nov 19, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 19, 2021 •
edited
Loading

Description

Fixes #8460
Fixes #8468

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe requested a review from a team November 19, 2021 21:39
@iwahbe iwahbe self-assigned this Nov 19, 2021
@iwahbe iwahbe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 19, 2021
@t0yv0
Copy link
Member

t0yv0 commented Nov 19, 2021

Looking good but it does need a test and changelog entry I think?

justinvp
justinvp approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add a changelog entry since it does fix a user visible diagnostic message and was reported by users?

@iwahbe iwahbe removed the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 19, 2021
@iwahbe iwahbe merged commit 87d8c7f into master Nov 19, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/8463/fix-python-path-resolution branch November 19, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees

@iwahbe iwahbe

Labels
language/python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User getting warning about 3.7 Python EOL Pulumi 3.18.0 python version
3 participants
@iwahbe @t0yv0 @justinvp